[MDS] Update Selectable props #6566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
valued-contributor
Skip-Changelog
huyaboo
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT and
xinruiba
as code owners
Signed-off-by: Huy Nguyen <[email protected]>
huyaboo
force-pushed
the
selectable-icon
branch
from
86eac4e to
bd9099c
Compare
BionIT
approved these changes
Apr 20, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 20, 2024
Signed-off-by: Huy Nguyen <[email protected]> (cherry picked from commit afb8cca) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
zhongnansu
pushed a commit
that referenced
this pull request
Apr 21, 2024
(cherry picked from commit afb8cca) Signed-off-by: Huy Nguyen <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Apr 22, 2024
LDrago27
pushed a commit
to LDrago27/OpenSearch-Dashboards
that referenced
this pull request
Jun 3, 2024
Signed-off-by: Huy Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disables the keyboard icon badge in the
DataSourceSelectablecomponent. Also sets thesingleSelectionto"always".Issues Resolved
Screenshot
Screen.Recording.2024-04-19.at.6.18.00.PM.mov
Testing the changes
Clicked and used
Tab+ arrow keys to check that the icon is disabled.Changelog
Check List
yarn test:jestyarn test:jest_integration