Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace] Dashboard admin(groups/users) implementation #6554

Merged
merged 37 commits into from
May 24, 2024
Merged
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
9488790
[Workspace] dashboard admin(groups/users) implementation and integrat…
yubonluo Apr 12, 2024
4209c2a
Modify change log
yubonluo Apr 15, 2024
8f06c87
solve code conflict
yubonluo Apr 17, 2024
32224a6
optimize the code
yubonluo Apr 19, 2024
87c4288
optimize the code
yubonluo Apr 19, 2024
ed1ff7f
Merge branch 'main' into main-admin-back
yubonluo Apr 19, 2024
c4cd56a
modify change log
yubonluo Apr 19, 2024
efb52e1
Merge branch 'main-admin-back' of github.com:yubonluo/OpenSearch-Dash…
yubonluo Apr 19, 2024
34f0164
modify change log
yubonluo Apr 19, 2024
f434c84
solve change log issue
yubonluo Apr 19, 2024
67237c5
Changeset file for PR #6554 created/updated
opensearch-changeset-bot[bot] Apr 22, 2024
ee48ea3
[Workspace] delete useless code
yubonluo Apr 22, 2024
783c498
Merge branch 'main' of github.com:opensearch-project/OpenSearch-Dashb…
yubonluo Apr 22, 2024
1e96d92
Merge branch 'main' into main-admin-back
yubonluo Apr 24, 2024
5105dd9
Changeset file for PR #6554 created/updated
opensearch-changeset-bot[bot] Apr 24, 2024
be8aa31
Merge branch 'main' into main-admin-back
yubonluo Apr 24, 2024
df772bc
Merge branch 'main' into main-admin-back
yubonluo Apr 25, 2024
0ebe3d5
Merge branch 'main' into main-admin-back
yubonluo Apr 25, 2024
ea629d1
Merge branch 'main' into main-admin-back
yubonluo Apr 25, 2024
5fcb298
solve code conflict
yubonluo Apr 30, 2024
f4a9dc3
delete useless code
yubonluo Apr 30, 2024
27d63f8
Merge branch 'main' into main-admin-back
yubonluo Apr 30, 2024
03cf65d
solve the code conflicts
yubonluo May 6, 2024
e1abe9f
Merge branch 'main-admin-back' of github.com:yubonluo/OpenSearch-Dash…
yubonluo May 6, 2024
eea9e86
Resolve the code conflict
yubonluo May 17, 2024
797698f
Optimize the code
yubonluo May 17, 2024
da8e238
Merge branch 'main' of github.com:opensearch-project/OpenSearch-Dashb…
yubonluo May 20, 2024
1e0b749
Add unit test to cover setupPermission in plugin.
yubonluo May 20, 2024
422ee19
Merge branch 'main' of github.com:opensearch-project/OpenSearch-Dashb…
yubonluo May 21, 2024
570e684
delete the logic of dynamic application config
yubonluo May 21, 2024
347ed1b
Merge branch 'main' into main-admin-back
yubonluo May 23, 2024
05a3454
Merge branch 'main' of github.com:opensearch-project/OpenSearch-Dashb…
yubonluo May 23, 2024
fd10be4
Default to OSD admin if security uninstall
yubonluo May 23, 2024
9010a31
Merge branch 'main-admin-back' of github.com:yubonluo/OpenSearch-Dash…
yubonluo May 23, 2024
a9569af
Default to OSD admin if security uninstall
yubonluo May 24, 2024
6dd28ef
Merge branch 'main' of github.com:opensearch-project/OpenSearch-Dashb…
yubonluo May 24, 2024
e6f9a18
Merge branch 'main' into main-admin-back
yubonluo May 24, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Changeset file for PR #6554 created/updated
opensearch-changeset-bot[bot] authored Apr 24, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 5105dd9abd4263fbacdb06a2dbc7bbdbaf0775b8
2 changes: 1 addition & 1 deletion changelogs/fragments/6554.yml
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
feat:
- Dashboard admin(groups/users) implementation. ([#6554](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6554))
- [Workspace] Dashboard admin(groups/users) implementation. ([#6554](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6554))

Unchanged files with check annotations Beta

let configUsers: string[];
// There may be calls to saved objects client before user get authenticated, need to add a try catch here as `getPrincipalsFromRequest` will throw error when user is not authenticated.
try {

Check warning on line 94 in src/plugins/workspace/server/plugin.ts

Codecov / codecov/patch

src/plugins/workspace/server/plugin.ts#L94

Added line #L94 was not covered by tests
({ groups = [], users = [] } = this.permissionControl!.getPrincipalsFromRequest(request));
} catch (e) {
return toolkit.next();

Check warning on line 97 in src/plugins/workspace/server/plugin.ts

Codecov / codecov/patch

src/plugins/workspace/server/plugin.ts#L97

Added line #L97 was not covered by tests
}
if (!!applicationConfig) {
[configGroups, configUsers] = await getApplicationOSDAdminConfig(

Check warning on line 101 in src/plugins/workspace/server/plugin.ts

Codecov / codecov/patch

src/plugins/workspace/server/plugin.ts#L101

Added line #L101 was not covered by tests
{ applicationConfig },
request
);
} else {
[configGroups, configUsers] = await getOSDAdminConfig(this.globalConfig$);

Check warning on line 106 in src/plugins/workspace/server/plugin.ts

Codecov / codecov/patch

src/plugins/workspace/server/plugin.ts#L106

Added line #L106 was not covered by tests
}
updateDashboardAdminStateForRequest(request, groups, users, configGroups, configUsers);
return toolkit.next();

Check warning on line 109 in src/plugins/workspace/server/plugin.ts

Codecov / codecov/patch

src/plugins/workspace/server/plugin.ts#L108-L109

Added lines #L108 - L109 were not covered by tests
});
this.workspaceSavedObjectsClientWrapper = new WorkspaceSavedObjectsClientWrapper(