-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MDS] Refactor dropdown header + Aggregate view UI #6541
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6541 +/- ##
==========================================
+ Coverage 32.93% 32.97% +0.04%
==========================================
Files 2260 2262 +2
Lines 45769 45824 +55
Branches 7200 7213 +13
==========================================
+ Hits 15075 15112 +37
- Misses 29984 29999 +15
- Partials 710 713 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
> | ||
{titleComponent} | ||
</EuiPanel> | ||
{titleComponent} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is minor. I think the titleComponet should be outside EuiContextMenuPanel since it is using a EuiPopoverTitle. I feel like it is not part of the EuiContextMenuPanel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Signed-off-by: Huy Nguyen <[email protected]>
Signed-off-by: Huy Nguyen <[email protected]>
Signed-off-by: Huy Nguyen <[email protected]>
Signed-off-by: Huy Nguyen <[email protected]>
Signed-off-by: Huy Nguyen <[email protected]>
Signed-off-by: Huy Nguyen <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-6541-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e34ca2b593ecf8d8c6caf547381cdddf5548a53c
# Push it to GitHub
git push --set-upstream origin backport/backport-6541-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-6541-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e34ca2b593ecf8d8c6caf547381cdddf5548a53c
# Push it to GitHub
git push --set-upstream origin backport/backport-6541-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
…t#6541) * Refactor dropdown header + aggregate view UI Signed-off-by: Huy Nguyen <[email protected]> * Refactor dropdown to use OuiPopoverTitle Signed-off-by: Huy Nguyen <[email protected]> * Update snapshots Signed-off-by: Huy Nguyen <[email protected]> * Refactor titleComponent Signed-off-by: Huy Nguyen <[email protected]> * Update snapshots Signed-off-by: Huy Nguyen <[email protected]> --------- Signed-off-by: Huy Nguyen <[email protected]> (cherry picked from commit e34ca2b)
…t#6541) * Refactor dropdown header + aggregate view UI Signed-off-by: Huy Nguyen <[email protected]> * Refactor dropdown to use OuiPopoverTitle Signed-off-by: Huy Nguyen <[email protected]> * Update snapshots Signed-off-by: Huy Nguyen <[email protected]> * Refactor titleComponent Signed-off-by: Huy Nguyen <[email protected]> * Update snapshots Signed-off-by: Huy Nguyen <[email protected]> --------- Signed-off-by: Huy Nguyen <[email protected]> (cherry picked from commit e34ca2b)
* Refactor dropdown header + aggregate view UI Signed-off-by: Huy Nguyen <[email protected]> * Refactor dropdown to use OuiPopoverTitle Signed-off-by: Huy Nguyen <[email protected]> * Update snapshots Signed-off-by: Huy Nguyen <[email protected]> * Refactor titleComponent Signed-off-by: Huy Nguyen <[email protected]> * Update snapshots Signed-off-by: Huy Nguyen <[email protected]> --------- Signed-off-by: Huy Nguyen <[email protected]> (cherry picked from commit e34ca2b) Signed-off-by: Huy Nguyen <[email protected]>
…t#6541) * Refactor dropdown header + aggregate view UI Signed-off-by: Huy Nguyen <[email protected]> * Refactor dropdown to use OuiPopoverTitle Signed-off-by: Huy Nguyen <[email protected]> * Update snapshots Signed-off-by: Huy Nguyen <[email protected]> * Refactor titleComponent Signed-off-by: Huy Nguyen <[email protected]> * Update snapshots Signed-off-by: Huy Nguyen <[email protected]> --------- Signed-off-by: Huy Nguyen <[email protected]>
Description
Refactors the UI Components for the datasource dropdown menu and the aggregate view. Specifically, the
disabled
cursor is removed and the dropdown header has the text vertically aligned. Some minor enhancements also made to aggregate view as well.Issues Resolved
#6533
Screenshot
Screen.Recording.2024-04-18.at.1.27.18.PM.mov
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration