Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS] Refactor dropdown header + Aggregate view UI #6541

Merged
merged 6 commits into from
Apr 19, 2024

Conversation

huyaboo
Copy link
Member

@huyaboo huyaboo commented Apr 18, 2024

Description

Refactors the UI Components for the datasource dropdown menu and the aggregate view. Specifically, the disabled cursor is removed and the dropdown header has the text vertically aligned. Some minor enhancements also made to aggregate view as well.

Issues Resolved

#6533

Screenshot

Screen.Recording.2024-04-18.at.1.27.18.PM.mov

Testing the changes

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@huyaboo huyaboo marked this pull request as ready for review April 18, 2024 20:29
@github-actions github-actions bot added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Apr 18, 2024
BionIT
BionIT previously approved these changes Apr 18, 2024
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.97%. Comparing base (d2d410b) to head (14921ef).
Report is 12 commits behind head on main.

❗ Current head 14921ef differs from pull request most recent head 531b4ec. Consider uploading reports for the commit 531b4ec to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6541      +/-   ##
==========================================
+ Coverage   32.93%   32.97%   +0.04%     
==========================================
  Files        2260     2262       +2     
  Lines       45769    45824      +55     
  Branches     7200     7213      +13     
==========================================
+ Hits        15075    15112      +37     
- Misses      29984    29999      +15     
- Partials      710      713       +3     
Flag Coverage Δ
Linux_1 32.97% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

>
{titleComponent}
</EuiPanel>
{titleComponent}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is minor. I think the titleComponet should be outside EuiContextMenuPanel since it is using a EuiPopoverTitle. I feel like it is not part of the EuiContextMenuPanel

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

zhongnansu
zhongnansu previously approved these changes Apr 19, 2024
Copy link
Member

@zhongnansu zhongnansu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

BionIT
BionIT previously approved these changes Apr 19, 2024
@huyaboo huyaboo dismissed stale reviews from BionIT and zhongnansu via 1c1499a April 19, 2024 18:34
Signed-off-by: Huy Nguyen <[email protected]>
@zhongnansu zhongnansu merged commit e34ca2b into opensearch-project:main Apr 19, 2024
65 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-6541-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e34ca2b593ecf8d8c6caf547381cdddf5548a53c
# Push it to GitHub
git push --set-upstream origin backport/backport-6541-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-6541-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-6541-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e34ca2b593ecf8d8c6caf547381cdddf5548a53c
# Push it to GitHub
git push --set-upstream origin backport/backport-6541-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-6541-to-2.x.

huyaboo added a commit to huyaboo/OpenSearch-Dashboards that referenced this pull request Apr 19, 2024
…t#6541)

* Refactor dropdown header + aggregate view UI

Signed-off-by: Huy Nguyen <[email protected]>

* Refactor dropdown to use OuiPopoverTitle

Signed-off-by: Huy Nguyen <[email protected]>

* Update snapshots

Signed-off-by: Huy Nguyen <[email protected]>

* Refactor titleComponent

Signed-off-by: Huy Nguyen <[email protected]>

* Update snapshots

Signed-off-by: Huy Nguyen <[email protected]>

---------

Signed-off-by: Huy Nguyen <[email protected]>
(cherry picked from commit e34ca2b)
huyaboo added a commit to huyaboo/OpenSearch-Dashboards that referenced this pull request Apr 19, 2024
…t#6541)

* Refactor dropdown header + aggregate view UI

Signed-off-by: Huy Nguyen <[email protected]>

* Refactor dropdown to use OuiPopoverTitle

Signed-off-by: Huy Nguyen <[email protected]>

* Update snapshots

Signed-off-by: Huy Nguyen <[email protected]>

* Refactor titleComponent

Signed-off-by: Huy Nguyen <[email protected]>

* Update snapshots

Signed-off-by: Huy Nguyen <[email protected]>

---------

Signed-off-by: Huy Nguyen <[email protected]>
(cherry picked from commit e34ca2b)
BionIT pushed a commit that referenced this pull request Apr 19, 2024
* Refactor dropdown header + aggregate view UI

Signed-off-by: Huy Nguyen <[email protected]>

* Refactor dropdown to use OuiPopoverTitle

Signed-off-by: Huy Nguyen <[email protected]>

* Update snapshots

Signed-off-by: Huy Nguyen <[email protected]>

* Refactor titleComponent

Signed-off-by: Huy Nguyen <[email protected]>

* Update snapshots

Signed-off-by: Huy Nguyen <[email protected]>

---------

Signed-off-by: Huy Nguyen <[email protected]>
(cherry picked from commit e34ca2b)

Signed-off-by: Huy Nguyen <[email protected]>
@huyaboo huyaboo deleted the aggregate-fix branch April 22, 2024 19:27
LDrago27 pushed a commit to LDrago27/OpenSearch-Dashboards that referenced this pull request Jun 3, 2024
…t#6541)

* Refactor dropdown header + aggregate view UI

Signed-off-by: Huy Nguyen <[email protected]>

* Refactor dropdown to use OuiPopoverTitle

Signed-off-by: Huy Nguyen <[email protected]>

* Update snapshots

Signed-off-by: Huy Nguyen <[email protected]>

* Refactor titleComponent

Signed-off-by: Huy Nguyen <[email protected]>

* Update snapshots

Signed-off-by: Huy Nguyen <[email protected]>

---------

Signed-off-by: Huy Nguyen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.14.0 valued-contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants