Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rename] kbn-pm in packages directory to osd-pm #65

Merged
merged 3 commits into from
Mar 12, 2021
Merged

[Rename] kbn-pm in packages directory to osd-pm #65

merged 3 commits into from
Mar 12, 2021

Conversation

mihirsoni
Copy link
Contributor

Signed-off-by: Mihir Soni [email protected]

Issue #, if available: #37

Description of changes: changes kbn-pm to osd-pm

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some issues with formatting in comments or docs but the code looks good. Once those are fixed then it should be good to merge so will just approve.

packages/osd-pm/README.md Outdated Show resolved Hide resolved
packages/osd-pm/src/README.md Outdated Show resolved Hide resolved
packages/osd-pm/src/utils/validate_dependencies.ts Outdated Show resolved Hide resolved
packages/osd-pm/src/utils/validate_dependencies.ts Outdated Show resolved Hide resolved
packages/osd-pm/README.md Outdated Show resolved Hide resolved
packages/osd-pm/src/utils/bootstrap_cache_file.ts Outdated Show resolved Hide resolved
packages/osd-pm/src/utils/project_checksums.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boktorbb boktorbb merged commit 728792c into opensearch-project:dashboards Mar 12, 2021
kavilla referenced this pull request in kavilla/OpenSearch-Dashboards Mar 19, 2021
* [Rename] kbn-pm in packages directory to osd-pm

Signed-off-by: Mihir Soni <[email protected]>

* [Rename] accomodate PR review feedback

Signed-off-by: Mihir Soni <[email protected]>

* [Rename] addressed review feedbacks

Signed-off-by: Mihir Soni <[email protected]>
kavilla pushed a commit that referenced this pull request Mar 20, 2021
* [Rename] kbn-pm in packages directory to osd-pm

Signed-off-by: Mihir Soni <[email protected]>

* [Rename] accomodate PR review feedback

Signed-off-by: Mihir Soni <[email protected]>

* [Rename] addressed review feedbacks

Signed-off-by: Mihir Soni <[email protected]>
mihirsoni added a commit that referenced this pull request Mar 20, 2021
* [Rename] kbn-pm in packages directory to osd-pm

Signed-off-by: Mihir Soni <[email protected]>

* [Rename] accomodate PR review feedback

Signed-off-by: Mihir Soni <[email protected]>

* [Rename] addressed review feedbacks

Signed-off-by: Mihir Soni <[email protected]>
wanglam pushed a commit to wanglam/OpenSearch-Dashboards that referenced this pull request Aug 3, 2023
* Add acl permission check functions

Signed-off-by: gaobinlong <[email protected]>

* Refactor some code

Signed-off-by: gaobinlong <[email protected]>

* Optimize some code

Signed-off-by: gaobinlong <[email protected]>

* Refactor acl

Signed-off-by: gaobinlong <[email protected]>

* Modify index mapping definition code

Signed-off-by: gaobinlong <[email protected]>

* Optimize code

Signed-off-by: gaobinlong <[email protected]>

* Optimize code

Signed-off-by: gaobinlong <[email protected]>

---------

Signed-off-by: gaobinlong <[email protected]>
raintygao pushed a commit to raintygao/OpenSearch-Dashboards that referenced this pull request Aug 4, 2023
* Add acl permission check functions

Signed-off-by: gaobinlong <[email protected]>

* Refactor some code

Signed-off-by: gaobinlong <[email protected]>

* Optimize some code

Signed-off-by: gaobinlong <[email protected]>

* Refactor acl

Signed-off-by: gaobinlong <[email protected]>

* Modify index mapping definition code

Signed-off-by: gaobinlong <[email protected]>

* Optimize code

Signed-off-by: gaobinlong <[email protected]>

* Optimize code

Signed-off-by: gaobinlong <[email protected]>

---------

Signed-off-by: gaobinlong <[email protected]>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Sep 14, 2023
* Add acl permission check functions

Signed-off-by: gaobinlong <[email protected]>

* Refactor some code

Signed-off-by: gaobinlong <[email protected]>

* Optimize some code

Signed-off-by: gaobinlong <[email protected]>

* Refactor acl

Signed-off-by: gaobinlong <[email protected]>

* Modify index mapping definition code

Signed-off-by: gaobinlong <[email protected]>

* Optimize code

Signed-off-by: gaobinlong <[email protected]>

* Optimize code

Signed-off-by: gaobinlong <[email protected]>

---------

Signed-off-by: gaobinlong <[email protected]>
Hailong-am pushed a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Sep 15, 2023
* Add acl permission check functions

Signed-off-by: gaobinlong <[email protected]>

* Refactor some code

Signed-off-by: gaobinlong <[email protected]>

* Optimize some code

Signed-off-by: gaobinlong <[email protected]>

* Refactor acl

Signed-off-by: gaobinlong <[email protected]>

* Modify index mapping definition code

Signed-off-by: gaobinlong <[email protected]>

* Optimize code

Signed-off-by: gaobinlong <[email protected]>

* Optimize code

Signed-off-by: gaobinlong <[email protected]>

---------

Signed-off-by: gaobinlong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants