-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rename] kbn-pm in packages directory to osd-pm #65
Conversation
Signed-off-by: Mihir Soni <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some issues with formatting in comments or docs but the code looks good. Once those are fixed then it should be good to merge so will just approve.
packages/osd-pm/src/utils/__fixtures__/opensearch-dashboards/package.json
Show resolved
Hide resolved
Signed-off-by: Mihir Soni <[email protected]>
Signed-off-by: Mihir Soni <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* [Rename] kbn-pm in packages directory to osd-pm Signed-off-by: Mihir Soni <[email protected]> * [Rename] accomodate PR review feedback Signed-off-by: Mihir Soni <[email protected]> * [Rename] addressed review feedbacks Signed-off-by: Mihir Soni <[email protected]>
* [Rename] kbn-pm in packages directory to osd-pm Signed-off-by: Mihir Soni <[email protected]> * [Rename] accomodate PR review feedback Signed-off-by: Mihir Soni <[email protected]> * [Rename] addressed review feedbacks Signed-off-by: Mihir Soni <[email protected]>
* [Rename] kbn-pm in packages directory to osd-pm Signed-off-by: Mihir Soni <[email protected]> * [Rename] accomodate PR review feedback Signed-off-by: Mihir Soni <[email protected]> * [Rename] addressed review feedbacks Signed-off-by: Mihir Soni <[email protected]>
* Add acl permission check functions Signed-off-by: gaobinlong <[email protected]> * Refactor some code Signed-off-by: gaobinlong <[email protected]> * Optimize some code Signed-off-by: gaobinlong <[email protected]> * Refactor acl Signed-off-by: gaobinlong <[email protected]> * Modify index mapping definition code Signed-off-by: gaobinlong <[email protected]> * Optimize code Signed-off-by: gaobinlong <[email protected]> * Optimize code Signed-off-by: gaobinlong <[email protected]> --------- Signed-off-by: gaobinlong <[email protected]>
* Add acl permission check functions Signed-off-by: gaobinlong <[email protected]> * Refactor some code Signed-off-by: gaobinlong <[email protected]> * Optimize some code Signed-off-by: gaobinlong <[email protected]> * Refactor acl Signed-off-by: gaobinlong <[email protected]> * Modify index mapping definition code Signed-off-by: gaobinlong <[email protected]> * Optimize code Signed-off-by: gaobinlong <[email protected]> * Optimize code Signed-off-by: gaobinlong <[email protected]> --------- Signed-off-by: gaobinlong <[email protected]>
* Add acl permission check functions Signed-off-by: gaobinlong <[email protected]> * Refactor some code Signed-off-by: gaobinlong <[email protected]> * Optimize some code Signed-off-by: gaobinlong <[email protected]> * Refactor acl Signed-off-by: gaobinlong <[email protected]> * Modify index mapping definition code Signed-off-by: gaobinlong <[email protected]> * Optimize code Signed-off-by: gaobinlong <[email protected]> * Optimize code Signed-off-by: gaobinlong <[email protected]> --------- Signed-off-by: gaobinlong <[email protected]>
* Add acl permission check functions Signed-off-by: gaobinlong <[email protected]> * Refactor some code Signed-off-by: gaobinlong <[email protected]> * Optimize some code Signed-off-by: gaobinlong <[email protected]> * Refactor acl Signed-off-by: gaobinlong <[email protected]> * Modify index mapping definition code Signed-off-by: gaobinlong <[email protected]> * Optimize code Signed-off-by: gaobinlong <[email protected]> * Optimize code Signed-off-by: gaobinlong <[email protected]> --------- Signed-off-by: gaobinlong <[email protected]>
Signed-off-by: Mihir Soni [email protected]
Issue #, if available: #37
Description of changes: changes kbn-pm to osd-pm
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.