-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix dynamic config API calls to pass correct input #6474
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6474 +/- ##
===========================================
+ Coverage 49.55% 62.68% +13.12%
===========================================
Files 2670 2081 -589
Lines 54290 40763 -13527
Branches 8878 7455 -1423
===========================================
- Hits 26906 25554 -1352
+ Misses 25720 13565 -12155
+ Partials 1664 1644 -20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
@SuZhou-Joe Since you have some prior context about https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6364/files could you please help review this one? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
All checks passed and ready for merging |
* update dynamic API calls to pass correct input Signed-off-by: Tianle Huang <[email protected]> * add unit tests Signed-off-by: Tianle Huang <[email protected]> * add changelog Signed-off-by: Tianle Huang <[email protected]> * revert yml Signed-off-by: Tianle Huang <[email protected]> --------- Signed-off-by: Tianle Huang <[email protected]> (cherry picked from commit 9a97b43) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
* update dynamic API calls to pass correct input Signed-off-by: Tianle Huang <[email protected]> * add unit tests Signed-off-by: Tianle Huang <[email protected]> * add changelog Signed-off-by: Tianle Huang <[email protected]> * revert yml Signed-off-by: Tianle Huang <[email protected]> --------- Signed-off-by: Tianle Huang <[email protected]> (cherry picked from commit 9a97b43) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
* update dynamic API calls to pass correct input Signed-off-by: Tianle Huang <[email protected]> * add unit tests Signed-off-by: Tianle Huang <[email protected]> * add changelog Signed-off-by: Tianle Huang <[email protected]> * revert yml Signed-off-by: Tianle Huang <[email protected]> --------- Signed-off-by: Tianle Huang <[email protected]> (cherry picked from commit 9a97b43) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* update dynamic API calls to pass correct input Signed-off-by: Tianle Huang <[email protected]> * add unit tests Signed-off-by: Tianle Huang <[email protected]> * add changelog Signed-off-by: Tianle Huang <[email protected]> * revert yml Signed-off-by: Tianle Huang <[email protected]> --------- Signed-off-by: Tianle Huang <[email protected]> (cherry picked from commit 9a97b43) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
During https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6364/files, we simplify the input to
getConfigurationClient
from a client to a request. We were focusing on the use case of other plugins to onboard onto it. However, we also have API use case which we missed during the related PR. So, this PR is to fix the issue by passing request into the function instead of a client.Currently it is not failing because the
asScoped
function doesn't fail. Check the code reference hereOpenSearch-Dashboards/src/core/server/opensearch/client/cluster_client.ts
Line 137 in eef417c
Issues Resolved
Screenshot
Testing the changes
Enable the following in YML.
call Get API
call update API
call get API again
call delete API
call get API again.
Check List
yarn test:jest
yarn test:jest_integration