-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MD] Add dropdown header to data source single selector #6431
[MD] Add dropdown header to data source single selector #6431
Conversation
4f83c10
to
8b21cb1
Compare
@xeniatup Hi Xenia, could you also help review the video and screenshot I attached, to make sure this is the correct UI/UX? Thanks |
src/plugins/data_source_management/public/components/drop_down_header.tsx
Outdated
Show resolved
Hide resolved
...s/data_source_management/public/components/data_source_selectable/data_source_selectable.tsx
Outdated
Show resolved
Hide resolved
src/plugins/data_source_management/public/components/drop_down_header.tsx
Outdated
Show resolved
Hide resolved
src/plugins/data_source_management/public/components/drop_down_header.tsx
Outdated
Show resolved
Hide resolved
...s/data_source_management/public/components/data_source_selectable/data_source_selectable.tsx
Outdated
Show resolved
Hide resolved
ba11c3c
to
37b6567
Compare
77aa3f5
to
7282698
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6431 +/- ##
==========================================
+ Coverage 49.55% 54.62% +5.06%
==========================================
Files 2670 2276 -394
Lines 54290 44615 -9675
Branches 8878 8294 -584
==========================================
- Hits 26906 24372 -2534
+ Misses 25720 18480 -7240
- Partials 1664 1763 +99
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
}) => { | ||
const dataSourceCounterPrefix = totalDataSourceCount === 1 ? 'DATA SOURCE' : 'DATA SOURCES'; | ||
const dataSourceCounter = | ||
activeDataSourceCount !== undefined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use activeDataSourceCount != null
to check undefined
and null
both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since bother activeCount and totalCount should be coming from somOptionsArray.length()
, Since .length on an array in JavaScript always returns a non-negative integer, we should be good to not do null check here
7282698
to
9ad8da1
Compare
Signed-off-by: Zhongnan Su <[email protected]>
9ad8da1
to
59d7fe8
Compare
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-6431-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a1c8b8c437e34d186f3bc44436f71b62371432f1
# Push it to GitHub
git push --set-upstream origin backport/backport-6431-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
…roject#6431) (cherry picked from commit a1c8b8c)
…roject#6431) (cherry picked from commit a1c8b8c)
…roject#6431) (cherry picked from commit a1c8b8c) Signed-off-by: Zhongnan Su <[email protected]>
…roject#6431) (cherry picked from commit a1c8b8c) Signed-off-by: Zhongnan Su <[email protected]>
(cherry picked from commit a1c8b8c) Signed-off-by: Zhongnan Su <[email protected]>
Description
Issues Resolved
#6429
Screenshot
iShot_2024-04-12_11.18.17.mp4
Testing the changes
Check List
yarn test:jest
yarn test:jest_integration