[Backport 2.x] [Workspace][Feature] Add ACL related functions #6405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* [Workspace] Add ACL related functions for workspace (#146) * [Workspace] Add acl related functions for workspace Signed-off-by: gaobinlong <[email protected]> * Minor change Signed-off-by: gaobinlong <[email protected]> --------- Signed-off-by: gaobinlong <[email protected]> * Modify changelog Signed-off-by: gaobinlong <[email protected]> * Add more unit test cases Signed-off-by: gaobinlong <[email protected]> * Modify test case Signed-off-by: gaobinlong <[email protected]> * Some minor change Signed-off-by: gaobinlong <[email protected]> * Add more test cases Signed-off-by: gaobinlong <[email protected]> * Optimize some code and the comments of the functions Signed-off-by: gaobinlong <[email protected]> * Add more comments for some basic functions Signed-off-by: gaobinlong <[email protected]> * Export more interfaces Signed-off-by: gaobinlong <[email protected]> * consume permissions in repository Signed-off-by: SuZhou-Joe <[email protected]> * feat: consume permissions in serializer Signed-off-by: SuZhou-Joe <[email protected]> * Add unit tests for consuming permissions in repository Signed-off-by: gaobinlong <[email protected]> * Remove double exclamation Signed-off-by: gaobinlong <[email protected]> * Rename some variables Signed-off-by: gaobinlong <[email protected]> * Remove duplicated semicolon Signed-off-by: gaobinlong <[email protected]> * Add permissions field to the mapping only if the permission control is enabled Signed-off-by: gaobinlong <[email protected]> * Fix test failure Signed-off-by: gaobinlong <[email protected]> * Add feature flag config to the yml file Signed-off-by: gaobinlong <[email protected]> * Make the comment of feature flag more clear Signed-off-by: gaobinlong <[email protected]> * Make comment more clear Signed-off-by: gaobinlong <[email protected]> * Remove management permission type Signed-off-by: gaobinlong <[email protected]> * Fix test failure Signed-off-by: gaobinlong <[email protected]> --------- Signed-off-by: gaobinlong <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: Josh Romero <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]> (cherry picked from commit 54c36fe) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
added
autocut
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT and
xinruiba
as code owners
Flyingliuhub
approved these changes
Apr 11, 2024
ananzh
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 54c36fe from #5084.