Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [BUG] Fix bug in data source aggregated view to change it to depend on displayAllCompatibleDataSources property to show the badge value #6323

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport f13537c from #6291.

…n displayAllCompatibleDataSources property to show the badge value (#6291)

* fix bug

Signed-off-by: Lu Yu <[email protected]>

* add tests

Signed-off-by: Lu Yu <[email protected]>

* add change log

Signed-off-by: Lu Yu <[email protected]>

* fix lint error

Signed-off-by: Lu Yu <[email protected]>

---------

Signed-off-by: Lu Yu <[email protected]>
(cherry picked from commit f13537c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.32%. Comparing base (49d696c) to head (c9d02b1).
Report is 1 commits behind head on 2.x.

Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #6323   +/-   ##
=======================================
  Coverage   67.32%   67.32%           
=======================================
  Files        3344     3344           
  Lines       64818    64818           
  Branches    10383    10383           
=======================================
+ Hits        43636    43639    +3     
+ Misses      18656    18653    -3     
  Partials     2526     2526           
Flag Coverage Δ
Linux_1 31.30% <ø> (ø)
Linux_2 55.39% <ø> (ø)
Linux_3 45.01% <100.00%> (+<0.01%) ⬆️
Linux_4 35.26% <0.00%> (ø)
Windows_1 31.33% <ø> (ø)
Windows_2 55.35% <ø> (ø)
Windows_3 45.02% <100.00%> (+0.01%) ⬆️
Windows_4 35.26% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BionIT BionIT merged commit 8b1cf1a into 2.x Apr 3, 2024
91 of 92 checks passed
@github-actions github-actions bot deleted the backport/backport-6291-to-2.x branch April 3, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports multiple datasource multiple datasource project seasoned-contributor v2.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants