Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual][Backport 2.x] add multi selectable data source component #6318

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

BionIT
Copy link
Collaborator

@BionIT BionIT commented Apr 2, 2024

Description

This manually backports 6aa59b2

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

…nsearch-project#6211)

* add multi selectable data source component

Signed-off-by: Lu Yu <[email protected]>

* update change log

Signed-off-by: Lu Yu <[email protected]>

* add tests

Signed-off-by: Lu Yu <[email protected]>

* add more test

Signed-off-by: Lu Yu <[email protected]>

* refactor to add config

Signed-off-by: Lu Yu <[email protected]>

* fix typo

Signed-off-by: Lu Yu <[email protected]>

* update snapshot

Signed-off-by: Lu Yu <[email protected]>

* add missing interface

Signed-off-by: Lu Yu <[email protected]>

---------

Signed-off-by: Lu Yu <[email protected]>
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 73.58491% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 67.31%. Comparing base (31d880e) to head (b444308).

Files Patch % Lines
...urce_multi_selectable/data_source_filter_group.tsx 80.00% 3 Missing and 3 partials ⚠️
...c/components/data_source_menu/data_source_menu.tsx 0.00% 4 Missing ⚠️
..._multi_selectable/data_source_multi_selectable.tsx 78.94% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #6318   +/-   ##
=======================================
  Coverage   67.31%   67.31%           
=======================================
  Files        3342     3344    +2     
  Lines       64765    64818   +53     
  Branches    10373    10383   +10     
=======================================
+ Hits        43594    43634   +40     
- Misses      18652    18657    +5     
- Partials     2519     2527    +8     
Flag Coverage Δ
Linux_1 31.30% <ø> (ø)
Linux_2 55.39% <ø> (ø)
Linux_3 44.99% <73.58%> (+0.03%) ⬆️
Linux_4 35.26% <3.77%> (-0.05%) ⬇️
Windows_1 31.33% <ø> (ø)
Windows_2 55.35% <ø> (ø)
Windows_3 45.01% <73.58%> (+0.04%) ⬆️
Windows_4 35.26% <3.77%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zhongnansu zhongnansu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zhongnansu zhongnansu added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Apr 2, 2024
@zhongnansu
Copy link
Member

@BionIT actually saw one test CI is failing, others are running, please also take a look and see if it's related to the change of this PR.

@xinruiba
Copy link
Member

xinruiba commented Apr 2, 2024

@BionIT actually saw one test CI is failing, others are running, please also take a look and see if it's related to the change of this PR.

+1, let's wait for all CI testing success. Thanks

@bandinib-amzn
Copy link
Member

Re-run failed job.

@BionIT
Copy link
Collaborator Author

BionIT commented Apr 3, 2024

@BionIT actually saw one test CI is failing, others are running, please also take a look and see if it's related to the change of this PR.

+1, let's wait for all CI testing success. Thanks

Thanks @zhongnansu @xinruiba @bandinib-amzn ! Yeah, it's due to another backport PR which is not merged, just merged that one and will wait until all tests pass

@BionIT BionIT merged commit 49d696c into opensearch-project:2.x Apr 3, 2024
66 checks passed
@BionIT BionIT added the v2.14.0 label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants