-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Manual][Backport 2.x] add multi selectable data source component #6318
[Manual][Backport 2.x] add multi selectable data source component #6318
Conversation
…nsearch-project#6211) * add multi selectable data source component Signed-off-by: Lu Yu <[email protected]> * update change log Signed-off-by: Lu Yu <[email protected]> * add tests Signed-off-by: Lu Yu <[email protected]> * add more test Signed-off-by: Lu Yu <[email protected]> * refactor to add config Signed-off-by: Lu Yu <[email protected]> * fix typo Signed-off-by: Lu Yu <[email protected]> * update snapshot Signed-off-by: Lu Yu <[email protected]> * add missing interface Signed-off-by: Lu Yu <[email protected]> --------- Signed-off-by: Lu Yu <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6318 +/- ##
=======================================
Coverage 67.31% 67.31%
=======================================
Files 3342 3344 +2
Lines 64765 64818 +53
Branches 10373 10383 +10
=======================================
+ Hits 43594 43634 +40
- Misses 18652 18657 +5
- Partials 2519 2527 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@BionIT actually saw one test CI is failing, others are running, please also take a look and see if it's related to the change of this PR. |
+1, let's wait for all CI testing success. Thanks |
Re-run failed job. |
Thanks @zhongnansu @xinruiba @bandinib-amzn ! Yeah, it's due to another backport PR which is not merged, just merged that one and will wait until all tests pass |
Description
This manually backports 6aa59b2
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jest
yarn test:jest_integration