[Backport 2.x] add version number to newly created datasource object #6198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* add version number to newly created datasource object Signed-off-by: Zilong Xia <[email protected]> * update attribute key from version to dataSourceVersion Signed-off-by: Zilong Xia <[email protected]> * add support and test coverage for custom auth type Signed-off-by: Zilong Xia <[email protected]> * fix ciGroup3 test case suite Create Datasource Wizard Signed-off-by: Zilong Xia <[email protected]> --------- Signed-off-by: Zilong Xia <[email protected]> Signed-off-by: ZilongX <[email protected]> (cherry picked from commit daccae7) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
opensearch-trigger-bot
bot
added
multiple datasource
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl and
BionIT
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6198 +/- ##
==========================================
+ Coverage 67.13% 67.18% +0.04%
==========================================
Files 3331 3332 +1
Lines 64391 64421 +30
Branches 10281 10286 +5
==========================================
+ Hits 43232 43279 +47
+ Misses 18706 18643 -63
- Partials 2453 2499 +46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ZilongX
approved these changes
Mar 19, 2024
Flyingliuhub
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport daccae7 from #6178.