[Discover] options button in canvas to toggle legacy mode #6170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavilla
requested review from
ananzh,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl and
BionIT
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6170 +/- ##
==========================================
+ Coverage 67.22% 67.24% +0.02%
==========================================
Files 3344 3344
Lines 64796 64796
Branches 10427 10427
==========================================
+ Hits 43556 43572 +16
+ Misses 18697 18683 -14
+ Partials 2543 2541 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ashwin-pc
previously approved these changes
Mar 16, 2024
Merged
1 task
kavilla
force-pushed
the
kavilla/legacy_toggle
branch
from
51f0c73
to
1929924
Compare
ruanyl
previously approved these changes
Mar 18, 2024
src/plugins/discover/public/application/view_components/canvas/index.tsx
Show resolved
Hide resolved
|
@kgcreative what do you think about this? |
|
@kavilla If we're able to align the button top-right instead of top-left, i think that's more consistent with other places where we do additional actions, but that's a minor nice-to-have |
like this @kgcreative?: |
kavilla
pushed a commit
to kavilla/opensearch-dashboards-functional-test
that referenced
this pull request
Mar 19, 2024
Update tests related to switching from legacy view within the Discover page. Requires: opensearch-project/OpenSearch-Dashboards#6170 Signed-off-by: Kawika Avilla <[email protected]>
1 task
[MANUAL CYPRESS TEST RUN RESULTS]✅ Cypress test run succeeded!Inputs:Link to results:https://github.com/opensearch-project/OpenSearch-Dashboards/actions/runs/8335506987 |
Removes top nav bar link and provides a button option. Issue: n/a Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
kavilla
force-pushed
the
kavilla/legacy_toggle
branch
from
c10d195
to
ee4381b
Compare
abbyhu2000
approved these changes
Mar 19, 2024
ashwin-pc
approved these changes
Mar 19, 2024
ruanyl
approved these changes
Mar 19, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 19, 2024
* [Discover] options button in canvas to toggle legacy mode Removes top nav bar link and provides a button option. Issue: n/a Signed-off-by: Kawika Avilla <[email protected]> (cherry picked from commit db9806d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
kavilla
added a commit
to opensearch-project/opensearch-dashboards-functional-test
that referenced
this pull request
Mar 19, 2024
Update tests related to switching from legacy view within the Discover page. Requires: opensearch-project/OpenSearch-Dashboards#6170 Signed-off-by: Kawika Avilla <[email protected]> Co-authored-by: Kawika Avilla <[email protected]>
opensearch-trigger-bot bot
pushed a commit
to opensearch-project/opensearch-dashboards-functional-test
that referenced
this pull request
Mar 19, 2024
Update tests related to switching from legacy view within the Discover page. Requires: opensearch-project/OpenSearch-Dashboards#6170 Signed-off-by: Kawika Avilla <[email protected]> Co-authored-by: Kawika Avilla <[email protected]> (cherry picked from commit 6a551e8)
ashwin-pc
pushed a commit
that referenced
this pull request
Mar 19, 2024
) * [Discover] options button in canvas to toggle legacy mode Removes top nav bar link and provides a button option. Issue: n/a Signed-off-by: Kawika Avilla <[email protected]> (cherry picked from commit db9806d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ananzh
pushed a commit
to opensearch-project/opensearch-dashboards-functional-test
that referenced
this pull request
Mar 19, 2024
Update tests related to switching from legacy view within the Discover page. Requires: opensearch-project/OpenSearch-Dashboards#6170 Signed-off-by: Kawika Avilla <[email protected]> Co-authored-by: Kawika Avilla <[email protected]> (cherry picked from commit 6a551e8) Co-authored-by: Kawika Avilla <[email protected]>
4 tasks
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Apr 7, 2024
…-project#6170) * [Discover] options button in canvas to toggle legacy mode Removes top nav bar link and provides a button option. Issue: n/a Signed-off-by: Kawika Avilla <[email protected]>
SuZhou-Joe
pushed a commit
to ruanyl/OpenSearch-Dashboards
that referenced
this pull request
Apr 7, 2024
…-project#6170) * [Discover] options button in canvas to toggle legacy mode Removes top nav bar link and provides a button option. Issue: n/a Signed-off-by: Kawika Avilla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes top nav bar link and provides a button option.
Issues Resolved
n/a
Screenshot
Check List
yarn test:jestyarn test:jest_integration