Bump axios to 0.28.0 in 2.x #6147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMoo-Miki
requested review from
ananzh,
kavilla,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn,
SuZhou-Joe and
ruanyl
as code owners
AMoo-Miki
force-pushed
the
bump-axios-2.x
branch
from
d567ca2 to
3198ab3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6147 +/- ##
==========================================
- Coverage 67.16% 67.15% -0.02%
==========================================
Files 3330 3330
Lines 64313 64313
Branches 10273 10273
==========================================
- Hits 43199 43190 -9
- Misses 18611 18621 +10
+ Partials 2503 2502 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
abbyhu2000
previously approved these changes
Mar 14, 2024
AMoo-Miki
force-pushed
the
bump-axios-2.x
branch
from
3198ab3 to
0726497
Compare
manasvinibs
previously approved these changes
Mar 14, 2024
manasvinibs
reviewed
Mar 14, 2024
CHANGELOG.md
Outdated
| @@ -10,6 +10,8 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
|
|
|||
| ### 🛡 Security | |||
|
|
|||
| - [CVE-2023-45857] Bump `axios` from `0.27.2` to `0.28.0` ([#5470](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5470)) | |||
There was a problem hiding this comment.
Do we want to update the PR number here? or separate changelog for just the axios?
SuZhou-Joe
reviewed
Mar 15, 2024
| @@ -37,7 +37,7 @@ import { ToolingLog } from '../tooling_log'; | |||
|
|
|||
| const isConcliftOnGetError = (error: any) => { | |||
| return ( | |||
| isAxiosResponseError(error) && error.config.method === 'GET' && error.response.status === 409 | |||
| isAxiosResponseError(error) && error.config?.method === 'GET' && error.response.status === 409 | |||
There was a problem hiding this comment.
Would like some comment here, is there any breaking change in axios in v0.28 that it may not bring config when throw error?
There was a problem hiding this comment.
Their changelog doesn't document any breaking changes; this is more than likely just fine tuning of the types def.
AMoo-Miki
force-pushed
the
bump-axios-2.x
branch
from
0726497 to
1856601
Compare
* bump oui to 1.5.1 Signed-off-by: Ashwin P Chandran <[email protected]> * Updates changelog --------- Signed-off-by: Ashwin P Chandran <[email protected]> (cherry picked from commit bd75107) Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
AMoo-Miki
force-pushed
the
bump-axios-2.x
branch
from
1856601 to
2ec92c3
Compare
ashwin-pc
approved these changes
Mar 18, 2024
kavilla
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses CVE-2023-45857 with [email protected].
Note 1: You might notice that axios@^1.13 which is dep of chromedriver also got a version bump. Being a nested dep, it is nothing to be reported on.
Note 2: Not backporting to 1.3; i will raise one there separately.
Check List
yarn test:jestyarn test:jest_integration