Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves connection pooling support for AWSSigV4 clients in data sources. #6135

Merged
merged 7 commits into from
Mar 15, 2024

Revert client pool changes from authentication method

18af6c9
Select commit
Loading
Failed to load commit list.
Merged

Improves connection pooling support for AWSSigV4 clients in data sources. #6135

Revert client pool changes from authentication method
18af6c9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 15, 2024 in 0s

67.26% (+0.03%) compared to 8c4f49a

View this Pull Request on Codecov

67.26% (+0.03%) compared to 8c4f49a

Details

Codecov Report

Attention: Patch coverage is 77.68595% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 67.26%. Comparing base (8c4f49a) to head (18af6c9).

Files Patch % Lines
...data_source/server/legacy/http_aws_es/connector.js 64.40% 21 Missing ⚠️
...r/auth_registry/authentication_methods_registry.ts 33.33% 1 Missing and 1 partial ⚠️
...ins/data_source/server/util/credential_provider.ts 0.00% 2 Missing ⚠️
...gins/data_source/server/client/configure_client.ts 95.23% 0 Missing and 1 partial ⚠️
...ta_source/server/legacy/configure_legacy_client.ts 95.83% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6135      +/-   ##
==========================================
+ Coverage   67.22%   67.26%   +0.03%     
==========================================
  Files        3333     3334       +1     
  Lines       64565    64639      +74     
  Branches    10391    10399       +8     
==========================================
+ Hits        43404    43478      +74     
- Misses      18628    18632       +4     
+ Partials     2533     2529       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov