[Multiple Datasource] Test connection schema validation for registered auth types #6109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… support for registered auth type Signed-off-by: Xinrui Bai <[email protected]>
xinruiba
changed the title
xinruiba
changed the title
xinruiba
changed the title
xinruiba
changed the title
xinruiba
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6109 +/- ##
==========================================
- Coverage 67.15% 67.13% -0.02%
==========================================
Files 3324 3324
Lines 64327 64330 +3
Branches 10345 10347 +2
==========================================
- Hits 43197 43188 -9
+ Misses 18652 18618 -34
- Partials 2478 2524 +46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xinruiba
changed the title
xinruiba
changed the title
Signed-off-by: Xinrui Bai <[email protected]>
xinruiba
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn and
SuZhou-Joe
as code owners
BionIT
reviewed
Mar 11, 2024
bandinib-amzn
previously approved these changes
Mar 11, 2024
… case Signed-off-by: Xinrui Bai <[email protected]>
xinruiba
added
backport 2.x
v2.13.0
multiple datasource
BionIT
previously approved these changes
Mar 11, 2024
bandinib-amzn
previously approved these changes
Mar 11, 2024
Signed-off-by: Xinrui Bai <[email protected]>
Signed-off-by: Xinrui Bai <[email protected]>
Signed-off-by: Xinrui Bai <[email protected]>
BionIT
approved these changes
Mar 11, 2024
Flyingliuhub
approved these changes
Mar 11, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 12, 2024
…d auth types (#6109) * [Token Exchange Unification] Test connextion router schema validation support for registered auth type Signed-off-by: Xinrui Bai <[email protected]> * Update changefile Signed-off-by: Xinrui Bai <[email protected]> * [UT] Add test cases for registered auth type, test connection failure case Signed-off-by: Xinrui Bai <[email protected]> * [UT] Update testing URL value to avoid linkchecker failure Signed-off-by: Xinrui Bai <[email protected]> * [UT] Update testing URL value to avoid linkchecker failure round2 Signed-off-by: Xinrui Bai <[email protected]> * [UT] Update testing URL value to avoid linkchecker failure round 3 Signed-off-by: Xinrui Bai <[email protected]> --------- Signed-off-by: Xinrui Bai <[email protected]> (cherry picked from commit 362ab1e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
Flyingliuhub
pushed a commit
that referenced
this pull request
Mar 12, 2024
…d auth types (#6109) (#6116) * [Token Exchange Unification] Test connextion router schema validation support for registered auth type Signed-off-by: Xinrui Bai <[email protected]> * Update changefile Signed-off-by: Xinrui Bai <[email protected]> * [UT] Add test cases for registered auth type, test connection failure case Signed-off-by: Xinrui Bai <[email protected]> * [UT] Update testing URL value to avoid linkchecker failure Signed-off-by: Xinrui Bai <[email protected]> * [UT] Update testing URL value to avoid linkchecker failure round2 Signed-off-by: Xinrui Bai <[email protected]> * [UT] Update testing URL value to avoid linkchecker failure round 3 Signed-off-by: Xinrui Bai <[email protected]> --------- Signed-off-by: Xinrui Bai <[email protected]> (cherry picked from commit 362ab1e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DataSourceManagement plugin support an interface to allow other plugins register their own Auth Types. This is the PR to provide test connection router schema validation support for those registered auth types.
Issues Resolved
Partially fixes #5692, #5838
Screenshot
TokenExchangeTestConnection.mov
Testing the changes
In the video, we execute following test steps:
Test connection success.
Check List
yarn test:jestyarn test:jest_integration