[Backport 2.x] [Multi Data Source] Render credential form registered from AuthMethod #6024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…#6002) * [TokenExchange] Render credential form registered from AuthMethod Signed-off-by: Xinrui Bai <[email protected]> * [UT] Add unittest to test registered credential form get rendered in create datasource page Signed-off-by: Xinrui Bai <[email protected]> * [UT] Update test case descriptions Signed-off-by: Xinrui Bai <[email protected]> * [Token Exchange] improve code format in create datasource page Signed-off-by: Xinrui Bai <[email protected]> * [UT] Add unit test for edit datasource page Signed-off-by: Xinrui Bai <[email protected]> * Update changelog file Signed-off-by: Xinrui Bai <[email protected]> * update yml config file to original status Signed-off-by: Xinrui Bai <[email protected]> * Resolving comments Signed-off-by: Xinrui Bai <[email protected]> * [UT] Add more unit test to cover existing auth type and plugin registered Auth type scenario Signed-off-by: Xinrui Bai <[email protected]> * Resolving comments, update pmport path Signed-off-by: Xinrui Bai <[email protected]> --------- Signed-off-by: Xinrui Bai <[email protected]> (cherry picked from commit 5ef10da) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
opensearch-trigger-bot
bot
added
multiple datasource
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn,
SuZhou-Joe and
ruanyl
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6024 +/- ##
=======================================
Coverage 67.08% 67.09%
=======================================
Files 3308 3308
Lines 63731 63749 +18
Branches 10168 10168
=======================================
+ Hits 42757 42773 +16
- Misses 18509 18511 +2
Partials 2465 2465
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BionIT
approved these changes
Mar 5, 2024
ZilongX
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 5ef10da from #6002.