Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add support for dynamic application configurations #6003

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 2c8d9d3 from #5855.

Copy link

codecov bot commented Mar 2, 2024

Codecov Report

Attention: Patch coverage is 85.57692% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 67.12%. Comparing base (bd04745) to head (1fcc362).

Files Patch % Lines
.../plugins/application_config/server/routes/index.ts 76.47% 8 Missing ⚠️
src/plugins/application_config/server/plugin.ts 78.94% 3 Missing and 1 partial ⚠️
.../plugins/application_config/server/string_utils.ts 77.77% 1 Missing and 1 partial ⚠️
...lication_config/server/opensearch_config_client.ts 97.61% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #6003      +/-   ##
==========================================
+ Coverage   67.08%   67.12%   +0.03%     
==========================================
  Files        3308     3312       +4     
  Lines       63731    63835     +104     
  Branches    10168    10176       +8     
==========================================
+ Hits        42757    42848      +91     
- Misses      18509    18520      +11     
- Partials     2465     2467       +2     
Flag Coverage Δ
Linux_1 35.21% <ø> (ø)
Linux_2 55.12% <ø> (ø)
Linux_3 44.63% <85.57%> (+0.12%) ⬆️
Linux_4 35.33% <ø> (ø)
Windows_1 35.23% <ø> (ø)
Windows_2 55.09% <ø> (ø)
Windows_3 44.64% <85.57%> (+0.13%) ⬆️
Windows_4 35.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tianleh
Copy link
Member

tianleh commented Mar 5, 2024

Please help backport.

@kavilla @BionIT @bandinib-amzn

@tianleh
Copy link
Member

tianleh commented Mar 5, 2024

cc @seraphjiang

* Add application configuration service

Signed-off-by: Tianle Huang <[email protected]>

* update API path name

Signed-off-by: Tianle Huang <[email protected]>

* implement two APIs/interfaces

Signed-off-by: Tianle Huang <[email protected]>

* expose get function for other plugins to use

Signed-off-by: Tianle Huang <[email protected]>

* update interfaces

Signed-off-by: Tianle Huang <[email protected]>

* implement the APIs and interfaces

Signed-off-by: Tianle Huang <[email protected]>

* add license and jsdoc

Signed-off-by: Tianle Huang <[email protected]>

* update docs

Signed-off-by: Tianle Huang <[email protected]>

* add more docs

Signed-off-by: Tianle Huang <[email protected]>

* update variable name

Signed-off-by: Tianle Huang <[email protected]>

* remove unnecessary dependency

Signed-off-by: Tianle Huang <[email protected]>

* format readme

Signed-off-by: Tianle Huang <[email protected]>

* use osd version

Signed-off-by: Tianle Huang <[email protected]>

* remove debugging info

Signed-off-by: Tianle Huang <[email protected]>

* update logging

Signed-off-by: Tianle Huang <[email protected]>

* remove lint js

Signed-off-by: Tianle Huang <[email protected]>

* remove logs

Signed-off-by: Tianle Huang <[email protected]>

* update name style

Signed-off-by: Tianle Huang <[email protected]>

* update

Signed-off-by: Tianle Huang <[email protected]>

* update function visibility and error function

Signed-off-by: Tianle Huang <[email protected]>

* fix unit test failures

Signed-off-by: Tianle Huang <[email protected]>

* add unit test

Signed-off-by: Tianle Huang <[email protected]>

* remove lint file

Signed-off-by: Tianle Huang <[email protected]>

* add more tests

Signed-off-by: Tianle Huang <[email protected]>

* add unit tests for routes

Signed-off-by: Tianle Huang <[email protected]>

* add remaining unit tests

Signed-off-by: Tianle Huang <[email protected]>

* add enabled to this plugin

Signed-off-by: Tianle Huang <[email protected]>

* update readme to mention experimental

Signed-off-by: Tianle Huang <[email protected]>

* update change log

Signed-off-by: Tianle Huang <[email protected]>

* dummy commit to trigger workflow rerun

Signed-off-by: Tianle Huang <[email protected]>

* remove experimental

Signed-off-by: Tianle Huang <[email protected]>

* add key to yml file

Signed-off-by: Tianle Huang <[email protected]>

* remove i18n

Signed-off-by: Tianle Huang <[email protected]>

* remove lint rc

Signed-off-by: Tianle Huang <[email protected]>

* update comment style

Signed-off-by: Tianle Huang <[email protected]>

* add input validation

Signed-off-by: Tianle Huang <[email protected]>

* update unit tests

Signed-off-by: Tianle Huang <[email protected]>

* prevent multiple registration

Signed-off-by: Tianle Huang <[email protected]>

* add return types

Signed-off-by: Tianle Huang <[email protected]>

* update readme wording

Signed-off-by: Tianle Huang <[email protected]>

* add unit test to the plugin class about double register

Signed-off-by: Tianle Huang <[email protected]>

* move related ymls

Signed-off-by: Tianle Huang <[email protected]>

* move validation to a function

Signed-off-by: Tianle Huang <[email protected]>

* use trimmed versions

Signed-off-by: Tianle Huang <[email protected]>

* reword changelog entry

Signed-off-by: Tianle Huang <[email protected]>

* readability

Signed-off-by: Tianle Huang <[email protected]>

* add back yml change

Signed-off-by: Tianle Huang <[email protected]>

---------

Signed-off-by: Tianle Huang <[email protected]>
(cherry picked from commit 2c8d9d3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@bandinib-amzn bandinib-amzn force-pushed the backport/backport-5855-to-2.x branch from 1339b00 to 1fcc362 Compare March 5, 2024 19:02
@bandinib-amzn bandinib-amzn merged commit 5b0432a into 2.x Mar 5, 2024
65 of 66 checks passed
@github-actions github-actions bot deleted the backport/backport-5855-to-2.x branch March 5, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports first-time-contributor v2.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants