Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual Backport 2.x] Fixes authentication_methods_registry.mock module (#5970) #5974

Conversation

bandinib-amzn
Copy link
Member

@bandinib-amzn bandinib-amzn commented Feb 27, 2024

Description

This is cherry pick of a449f70 from #5970

Issues Resolved

#5952

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.06%. Comparing base (f6bbeb4) to head (b8ab4b6).

Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #5974   +/-   ##
=======================================
  Coverage   67.06%   67.06%           
=======================================
  Files        3308     3308           
  Lines       63690    63690           
  Branches    10160    10160           
=======================================
  Hits        42712    42712           
  Misses      18512    18512           
  Partials     2466     2466           
Flag Coverage Δ
Linux_1 35.21% <ø> (ø)
Linux_2 55.13% <ø> (ø)
Linux_3 44.40% <ø> (?)
Linux_4 35.32% <ø> (ø)
Windows_1 35.24% <ø> (ø)
Windows_2 55.10% <ø> (ø)
Windows_3 44.42% <ø> (ø)
Windows_4 35.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bandinib-amzn bandinib-amzn force-pushed the backport/backport-5970-to-2.x branch from 8f9be2b to b8ab4b6 Compare February 27, 2024 23:32
@bandinib-amzn bandinib-amzn merged commit c659994 into opensearch-project:2.x Feb 28, 2024
67 checks passed
@bandinib-amzn bandinib-amzn deleted the backport/backport-5970-to-2.x branch February 28, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants