[Manual Backport 2.x]Fix missing customApiRegistryPromise param for test connection (#5944) #5971
Conversation
…earch-project#5944) * fix missing param and add changelog and test Signed-off-by: Lu Yu <[email protected]> * change pr number Signed-off-by: Lu Yu <[email protected]> * remove dangling changelog Signed-off-by: Lu Yu <[email protected]> --------- Signed-off-by: Lu Yu <[email protected]>
BionIT
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn and
SuZhou-Joe
as code owners
CHANGELOG.md
Outdated
| @@ -81,6 +81,9 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
| - [Discover] Fix missing index pattern field from breaking Discover [#5626](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5626) | |||
| - [BUG] Remove duplicate sample data as id 90943e30-9a47-11e8-b64d-95841ca0b247 ([5668](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5668)) | |||
| - [BUG][Multiple Datasource] Fix datasource testing connection unexpectedly passed with wrong endpoint [#5663](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5663) | |||
| - [Table Visualization] Fix filter action buttons for split table aggregations ([#5619](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5619)) | |||
There was a problem hiding this comment.
It seems like that you include the others changes here.
There was a problem hiding this comment.
I didn't include it, but it is hanging here since it was left alone from the auto backport https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5823/files, and original PR has the changelog https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5619/files
If I remove it, it will not be in 2.x but it should. How should we handle it? @bandinib-amzn @ashwin-pc
There was a problem hiding this comment.
According to Backport workflow, we skip changelog for backport PR. That's why we don't see changelog in autocut backport. I'm not sure if we use changelog from 2.x branch.
So for this PR, I would suggest keep only your changes in CHANGELOG.md.
@ashwin-pc Can you tell us what is best practice for changelog when we manually backport PR?
There was a problem hiding this comment.
I removed the dangling changelog for now
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #5971 +/- ##
==========================================
- Coverage 67.05% 66.93% -0.12%
==========================================
Files 3305 2599 -706
Lines 63657 48940 -14717
Branches 10158 8786 -1372
==========================================
- Hits 42684 32760 -9924
+ Misses 18507 14039 -4468
+ Partials 2466 2141 -325
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Description
This is cherry pick of 6d5560e from #5944
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integration