-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security] Updates dev guide for security #5736
[Security] Updates dev guide for security #5736
Conversation
Signed-off-by: Ashwin P Chandran <[email protected]>
Signed-off-by: Ashwin P Chandran <[email protected]>
Signed-off-by: Ashwin P Chandran <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5736 +/- ##
=======================================
Coverage 67.03% 67.03%
=======================================
Files 3296 3296
Lines 63343 63343
Branches 10087 10087
=======================================
Hits 42465 42465
Misses 18429 18429
Partials 2449 2449
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ashwin P Chandran <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-5736-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1a0cf47fe646458938e0892e4ed73326d581a122
# Push it to GitHub
git push --set-upstream origin backport/backport-5736-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
* [Docs] Updates dev guide for security Signed-off-by: Ashwin P Chandran <[email protected]> * better default creds Signed-off-by: Ashwin P Chandran <[email protected]> * undo changelog changes Signed-off-by: Ashwin P Chandran <[email protected]> * Adds sample password Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> (cherry picked from commit 1a0cf47) Signed-off-by: Miki <[email protected]>
* [Docs] Updates dev guide for security Signed-off-by: Ashwin P Chandran <[email protected]> * better default creds Signed-off-by: Ashwin P Chandran <[email protected]> * undo changelog changes Signed-off-by: Ashwin P Chandran <[email protected]> * Adds sample password Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: yujin-emma <[email protected]>
* [Docs] Updates dev guide for security * better default creds * undo changelog changes * Adds sample password --------- (cherry picked from commit 1a0cf47) Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Miki <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]>
Description
The instructions in the dev guide were insufficient to setup OSD with security for development. Updated the instructions to what worked for me.
Issues Resolved
Screenshot
Testing the changes
Follow the instructions and see of you can setup OSD with security for development.
Check List
yarn test:jest
yarn test:jest_integration