[Data Explorer] Adding PPL to query language selector #5623

abbyhu2000 · 2023-12-15T20:02:40Z

Description

A quick solution for adding navigation from data explorer page to log explorer page by adding the option of choosing PPL in the query language selector in the top nav bar.

Issues Resolved

resolves part of #5504

Screenshot

Testing the changes

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

codecov · 2023-12-15T20:17:30Z

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (6710ec3) 67.02% compared to head (e590676) 67.01%.
Report is 8 commits behind head on main.

Files	Patch %	Lines
...public/ui/query_string_input/language_switcher.tsx	40.00%	14 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5623      +/-   ##
==========================================
- Coverage   67.02%   67.01%   -0.02%     
==========================================
  Files        3294     3294              
  Lines       63309    63328      +19     
  Branches    10071    10076       +5     
==========================================
+ Hits        42435    42440       +5     
- Misses      18430    18442      +12     
- Partials     2444     2446       +2

Flag	Coverage Δ
Linux_1	`35.24% <ø> (ø)`
Linux_2	`55.19% <ø> (ø)`
Linux_3	`43.86% <40.00%> (-0.02%)`	⬇️
Linux_4	`35.34% <ø> (ø)`
Windows_1	`35.26% <ø> (ø)`
Windows_2	`55.15% <ø> (ø)`
Windows_3	`43.88% <40.00%> (-0.01%)`	⬇️
Windows_4	`35.34% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ashwin-pc

Can we make this a lot simpler? Like all we want is a simple if condition where the existing pop over is placed to be replaced with a new popp er with the new options if the current app is data explorer and observability APIs are available. Feel like the whole change should be contained in just a single file that we can remove when this hard coded logic isn't needed.

Also add a to-do with an issue that call out that this is a temporary solution and needs to be removed ASAP and add the issue URL to the code comment

src/plugins/data/public/types.ts

src/plugins/data/public/ui/query_string_input/language_switcher.tsx

src/plugins/discover/public/build_services.ts

abbyhu2000 · 2023-12-19T00:39:04Z

Created a follow-up issue for this: #5628

SuZhou-Joe · 2023-12-21T02:48:23Z

src/plugins/data/public/ui/query_string_input/language_switcher.tsx

+  const { application } = opensearchDashboards.services;
+  const currentApp$ = application?.currentAppId$;
+  let useNewQuerySelector;
+  application?.applications$.subscribe((applications) => {


This subscribe should be wrapped inside a useEffect I suppose?

SuZhou-Joe · 2023-12-21T02:55:19Z

src/plugins/data/public/ui/query_string_input/language_switcher.tsx

+    });
+  });
+
+  const dataExplorerOptions = [


Can we add an enum for these language options like

enum ENUM_LANGUAGES { DQL = "DQL" }

? And I suggest adding an id field inside options though under context of language, label no need to wrapped by i18n.

We will still need i18n since its purpose is to individually identify the language name. e.g. data.query.queryBar.dqlLanguageName

Signed-off-by: abbyhu2000 <[email protected]>

ashwin-pc

Just 2 minor changes, the rest of the code looks good to me :)

abbyhu2000 · 2024-01-17T23:15:31Z

Taking off the 2.12 tag since the team decided to leave this out of 2.12 release.

Only adds the quick startup for OpenSearch cluster with a SQL plugin and observability with: ``` yarn opensearch snapshot --sql ``` Also, adds SQL to the language selector stolen shamelessly from opensearch-project#5623 Next steps to intercept and send to SQL API or just transform basic syntax to DSL Signed-off-by: Kawika Avilla <[email protected]>

abbyhu2000 · 2024-03-14T18:43:00Z

Close this PR since we want to build a more unified experience for query language.

Only adds the quick startup for OpenSearch cluster with a SQL plugin and observability with: ``` yarn opensearch snapshot --sql ``` Also, adds SQL to the language selector stolen shamelessly from opensearch-project#5623 Next steps to intercept and send to SQL API or just transform basic syntax to DSL Signed-off-by: Kawika Avilla <[email protected]>

Only adds the quick startup for OpenSearch cluster with a SQL plugin and observability with: ``` yarn opensearch snapshot --sql ``` Also, adds SQL to the language selector stolen shamelessly from opensearch-project#5623 Next steps to intercept and send to SQL API or just transform basic syntax to DSL Signed-off-by: Kawika Avilla <[email protected]> Working query enhance Signed-off-by: Kawika Avilla <[email protected]> Reget search enhance Signed-off-by: Kawika Avilla <[email protected]> data frames Signed-off-by: Kawika Avilla <[email protected]> temp state need to pass df Signed-off-by: Kawika Avilla <[email protected]> sending data frame Signed-off-by: Kawika Avilla <[email protected]> gets df type Signed-off-by: Kawika Avilla <[email protected]> add some small ui things Signed-off-by: Kawika Avilla <[email protected]> move back query language switcher Signed-off-by: Kawika Avilla <[email protected]> updating side panel Signed-off-by: Kawika Avilla <[email protected]> add ui config on query enhancement Signed-off-by: Kawika Avilla <[email protected]> support query string input Signed-off-by: Kawika Avilla <[email protected]> update to say search bar Signed-off-by: Kawika Avilla <[email protected]> update ppl to call once Signed-off-by: Kawika Avilla <[email protected]> update when fields update Signed-off-by: Kawika Avilla <[email protected]> add unknown Signed-off-by: Kawika Avilla <[email protected]>

* [MQL] support different query languages Only adds the quick startup for OpenSearch cluster with a SQL plugin and observability with: ``` yarn opensearch snapshot --sql ``` Also, adds SQL to the language selector stolen shamelessly from #5623 Next steps to intercept and send to SQL API or just transform basic syntax to DSL Signed-off-by: Kawika Avilla <[email protected]> Working query enhance Signed-off-by: Kawika Avilla <[email protected]> Reget search enhance Signed-off-by: Kawika Avilla <[email protected]> data frames Signed-off-by: Kawika Avilla <[email protected]> temp state need to pass df Signed-off-by: Kawika Avilla <[email protected]> sending data frame Signed-off-by: Kawika Avilla <[email protected]> gets df type Signed-off-by: Kawika Avilla <[email protected]> add some small ui things Signed-off-by: Kawika Avilla <[email protected]> move back query language switcher Signed-off-by: Kawika Avilla <[email protected]> updating side panel Signed-off-by: Kawika Avilla <[email protected]> add ui config on query enhancement Signed-off-by: Kawika Avilla <[email protected]> support query string input Signed-off-by: Kawika Avilla <[email protected]> update to say search bar Signed-off-by: Kawika Avilla <[email protected]> update ppl to call once Signed-off-by: Kawika Avilla <[email protected]> update when fields update Signed-off-by: Kawika Avilla <[email protected]> add unknown Signed-off-by: Kawika Avilla <[email protected]> * clean up Signed-off-by: Kawika Avilla <[email protected]> * more clean up Signed-off-by: Kawika Avilla <[email protected]> * clean up licenses Signed-off-by: Kawika Avilla <[email protected]> --------- Signed-off-by: Kawika Avilla <[email protected]>

* [MQL] support different query languages Only adds the quick startup for OpenSearch cluster with a SQL plugin and observability with: ``` yarn opensearch snapshot --sql ``` Also, adds SQL to the language selector stolen shamelessly from opensearch-project#5623 Next steps to intercept and send to SQL API or just transform basic syntax to DSL Signed-off-by: Kawika Avilla <[email protected]> Working query enhance Signed-off-by: Kawika Avilla <[email protected]> Reget search enhance Signed-off-by: Kawika Avilla <[email protected]> data frames Signed-off-by: Kawika Avilla <[email protected]> temp state need to pass df Signed-off-by: Kawika Avilla <[email protected]> sending data frame Signed-off-by: Kawika Avilla <[email protected]> gets df type Signed-off-by: Kawika Avilla <[email protected]> add some small ui things Signed-off-by: Kawika Avilla <[email protected]> move back query language switcher Signed-off-by: Kawika Avilla <[email protected]> updating side panel Signed-off-by: Kawika Avilla <[email protected]> add ui config on query enhancement Signed-off-by: Kawika Avilla <[email protected]> support query string input Signed-off-by: Kawika Avilla <[email protected]> update to say search bar Signed-off-by: Kawika Avilla <[email protected]> update ppl to call once Signed-off-by: Kawika Avilla <[email protected]> update when fields update Signed-off-by: Kawika Avilla <[email protected]> add unknown Signed-off-by: Kawika Avilla <[email protected]> * clean up Signed-off-by: Kawika Avilla <[email protected]> * more clean up Signed-off-by: Kawika Avilla <[email protected]> * clean up licenses Signed-off-by: Kawika Avilla <[email protected]> --------- Signed-off-by: Kawika Avilla <[email protected]> Cleanup unused helper function Signed-off-by: Kawika Avilla <[email protected]> create index pattern somewhat working Signed-off-by: Kawika Avilla <[email protected]>

abbyhu2000 added the data explorer Issues related to the Data Explorer project label Dec 15, 2023

github-actions bot added the distinguished-contributor label Dec 15, 2023

abbyhu2000 force-pushed the query_selector_new branch from 0cf4507 to fb3fcb8 Compare December 15, 2023 20:03

abbyhu2000 marked this pull request as ready for review December 15, 2023 20:03

abbyhu2000 requested review from ananzh, kavilla, AMoo-Miki, ashwin-pc, joshuarrrr, zengyan-amazon, kristenTian, zhongnansu, manasvinibs, ZilongX, Flyingliuhub, BSFishy, curq, bandinib-amzn and SuZhou-Joe as code owners December 15, 2023 20:03

abbyhu2000 changed the title ~~Query selector new~~ Adding PPL to query language selector Dec 15, 2023

abbyhu2000 changed the title ~~Adding PPL to query language selector~~ [Data Explorer] Adding PPL to query language selector Dec 15, 2023

abbyhu2000 force-pushed the query_selector_new branch from fb3fcb8 to 65db3a9 Compare December 15, 2023 20:06

ashwin-pc reviewed Dec 15, 2023

View reviewed changes

src/plugins/data/public/types.ts Outdated Show resolved Hide resolved

ruanyl reviewed Dec 18, 2023

View reviewed changes

abbyhu2000 force-pushed the query_selector_new branch 2 times, most recently from d42e7a1 to aaa775e Compare December 20, 2023 22:38

SuZhou-Joe reviewed Dec 21, 2023

View reviewed changes

abbyhu2000 added the v2.12.0 label Dec 21, 2023

abbyhu2000 added 11 commits January 3, 2024 19:15

working dropdown

217f7b9

Signed-off-by: abbyhu2000 <[email protected]>

top nav work with data explorer

ad77712

Signed-off-by: abbyhu2000 <[email protected]>

comment

75bff8d

Signed-off-by: abbyhu2000 <[email protected]>

dropdown working

f3b4c45

Signed-off-by: abbyhu2000 <[email protected]>

some progress on test if observability exist

f01be2d

Signed-off-by: abbyhu2000 <[email protected]>

redirect to observability page

6723808

Signed-off-by: abbyhu2000 <[email protected]>

Query selector working

35212a4

Signed-off-by: abbyhu2000 <[email protected]>

add changelog

0b5b098

Signed-off-by: abbyhu2000 <[email protected]>

cleanup

257a9bf

Signed-off-by: abbyhu2000 <[email protected]>

add follow up issue comment

d8d2e5c

Signed-off-by: abbyhu2000 <[email protected]>

rebase and address comments

5bf8243

Signed-off-by: abbyhu2000 <[email protected]>

abbyhu2000 force-pushed the query_selector_new branch from 80ede38 to 5bf8243 Compare January 3, 2024 20:20

fix unit test

e590676

Signed-off-by: abbyhu2000 <[email protected]>

ashwin-pc reviewed Jan 8, 2024

View reviewed changes

abbyhu2000 added v2.13.0 and removed v2.12.0 labels Jan 17, 2024

abbyhu2000 closed this Mar 14, 2024

kavilla mentioned this pull request Apr 22, 2024

[MQL] support different query languages #6595

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Data Explorer] Adding PPL to query language selector #5623

[Data Explorer] Adding PPL to query language selector #5623

abbyhu2000 commented Dec 15, 2023

codecov bot commented Dec 15, 2023 •

edited

Loading

ashwin-pc left a comment

abbyhu2000 commented Dec 19, 2023

SuZhou-Joe Dec 21, 2023

ashwin-pc Jan 8, 2024

SuZhou-Joe Dec 21, 2023 •

edited

Loading

ashwin-pc Jan 8, 2024

ashwin-pc left a comment

abbyhu2000 commented Jan 17, 2024

abbyhu2000 commented Mar 14, 2024

[Data Explorer] Adding PPL to query language selector #5623

[Data Explorer] Adding PPL to query language selector #5623

Conversation

abbyhu2000 commented Dec 15, 2023

Description

Issues Resolved

Screenshot

Testing the changes

Check List

codecov bot commented Dec 15, 2023 • edited Loading

Codecov Report

ashwin-pc left a comment

Choose a reason for hiding this comment

abbyhu2000 commented Dec 19, 2023

SuZhou-Joe Dec 21, 2023

Choose a reason for hiding this comment

ashwin-pc Jan 8, 2024

Choose a reason for hiding this comment

SuZhou-Joe Dec 21, 2023 • edited Loading

Choose a reason for hiding this comment

ashwin-pc Jan 8, 2024

Choose a reason for hiding this comment

ashwin-pc left a comment

Choose a reason for hiding this comment

abbyhu2000 commented Jan 17, 2024

abbyhu2000 commented Mar 14, 2024

codecov bot commented Dec 15, 2023 •

edited

Loading

SuZhou-Joe Dec 21, 2023 •

edited

Loading