Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [OSCI][Fix][Discover]Prevent Adding Timefield to the Side Nav Selected Fields on Column Removal #5617

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 0a33d4a from #5537.

…d Fields on Column Removal (#5537)

* added in a filter for columns before rendering the panel, remove timeField if it was not previously chosen.
* fix issue 5538 too
---------

Signed-off-by: qiwen li <[email protected]>
Signed-off-by: Qiwen Li <[email protected]>
(cherry picked from commit 0a33d4a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (561ca46) 67.05% compared to head (d3715cd) 67.05%.
Report is 1 commits behind head on 2.x.

Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #5617   +/-   ##
=======================================
  Coverage   67.05%   67.05%           
=======================================
  Files        3292     3292           
  Lines       63345    63345           
  Branches    10062    10062           
=======================================
  Hits        42478    42478           
  Misses      18424    18424           
  Partials     2443     2443           
Flag Coverage Δ
Linux_1 35.24% <ø> (ø)
Linux_2 55.23% <ø> (ø)
Linux_3 43.88% <ø> (+0.01%) ⬆️
Linux_4 35.47% <ø> (ø)
Windows_1 35.26% <ø> (ø)
Windows_2 55.20% <ø> (ø)
Windows_3 43.89% <ø> (ø)
Windows_4 35.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@manasvinibs manasvinibs merged commit bc45961 into 2.x Dec 15, 2023
91 of 92 checks passed
@github-actions github-actions bot deleted the backport/backport-5537-to-2.x branch December 15, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports bug Something isn't working discover for discover reinvent first-time-contributor v2.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants