Remove duplicate sample data as id 90943e30-9a47-11e8-b64d-95841ca0b2… #5591
Conversation
zhyuanqi
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq and
bandinib-amzn
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5591 +/- ##
==========================================
+ Coverage 66.93% 66.98% +0.04%
==========================================
Files 3293 3293
Lines 63285 63287 +2
Branches 10061 10062 +1
==========================================
+ Hits 42362 42394 +32
+ Misses 18459 18453 -6
+ Partials 2464 2440 -24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
It looks like this was my mistake, introduced in #4339, so I can vouch for it being unintentional 😁 I am interested to understand what error or issues it causes - @zhyuanqi how did you happen to discover it? |
|
Hi I will add the change log and signoff in the next revision. Thanks. |
…opensearch-project#5577) * [BUG][Data] Support for custom filters with heterogeneous data fields When enabling the advanced setting `courier:ignoreFilterIfFieldNotInIndex` Custom OpenSearch Query DSL filters could technically be applied to index patterns that map to indices that are not exactly the same. Since the custom query filter is a user input then users can really type anything that they need. Or any field that they know is present but we do not know for sure. Therefore, we can check if the id which is the index pattern title to check if we should apply the filter or not. Issue resolved: https://github.com/opensearch-project/dashboards-visualizations/issues/281 I believe issue: opensearch-project#5423 Should closed as that is expected functionality. Signed-off-by: Kawika Avilla <[email protected]> * [Cleanup] utilize the same helper function Originally when implementing the fix the historical comment caused concern about potential breaking changes. But after discussion, we decided it is more clear to consolidate the helper functions. Signed-off-by: Kawika Avilla <[email protected]>
…opensearch-project#5577) * [BUG][Data] Support for custom filters with heterogeneous data fields When enabling the advanced setting `courier:ignoreFilterIfFieldNotInIndex` Custom OpenSearch Query DSL filters could technically be applied to index patterns that map to indices that are not exactly the same. Since the custom query filter is a user input then users can really type anything that they need. Or any field that they know is present but we do not know for sure. Therefore, we can check if the id which is the index pattern title to check if we should apply the filter or not. Issue resolved: https://github.com/opensearch-project/dashboards-visualizations/issues/281 I believe issue: opensearch-project#5423 Should closed as that is expected functionality. Signed-off-by: Kawika Avilla <[email protected]> * [Cleanup] utilize the same helper function Originally when implementing the fix the historical comment caused concern about potential breaking changes. But after discussion, we decided it is more clear to consolidate the helper functions. Signed-off-by: Kawika Avilla <[email protected]>
|
Close this pull request as created a new one #5668 |
Description
Remove duplicate sample data as id 90943e30-9a47-11e8-b64d-95841ca0b247 appears twice on line 273 and 404. Duplicate entry.
Issues Resolved
No related issue with it.
Testing the changes
Since we only delete old record of id 90943e30-9a47-11e8-b64d-95841ca0b247. No record still exists on line 404. Visualization stays the same
Check List
yarn test:jest(Two tests failed in my local. log_rotator.test.ts and create_os_package_tasks.test.ts. I don't think they are related to my change though)yarn test:jest_integration