Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [BUG][Data] Support for custom filters with heterogeneous data fields #5584

Merged
merged 1 commit into from
Dec 13, 2023

Commits on Dec 7, 2023

  1. [BUG][Data] Support for custom filters with heterogeneous data fields (

    …#5577)
    
    * [BUG][Data] Support for custom filters with heterogeneous data fields
    
    When enabling the advanced setting `courier:ignoreFilterIfFieldNotInIndex`
    Custom OpenSearch Query DSL filters could technically be applied to index
    patterns that map to indices that are not exactly the same. Since the
    custom query filter is a user input then users can really type anything
    that they need. Or any field that they know is present but we do not know
    for sure.
    
    Therefore, we can check if the id which is the index pattern title to check
    if we should apply the filter or not.
    
    Issue resolved:
    https://github.com/opensearch-project/dashboards-visualizations/issues/281
    
    I believe issue:
    #5423
    
    Should closed as that is expected functionality.
    
    Signed-off-by: Kawika Avilla <[email protected]>
    
    * [Cleanup] utilize the same helper function
    
    Originally when implementing the fix the historical comment caused concern about
    potential breaking changes.
    
    But after discussion, we decided it is more clear to consolidate the helper functions.
    
    Signed-off-by: Kawika Avilla <[email protected]>
    (cherry picked from commit 805400d)
    Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
    
    # Conflicts:
    #	CHANGELOG.md
    github-actions[bot] committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    f5d48ea View commit details
    Browse the repository at this point in the history