Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Replace edit_index_pattern link #553

Merged
merged 1 commit into from
Jun 26, 2021

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Jun 25, 2021

Description

Replacing previous upstream reference within the edit index
pattern page. This does not fully resolve the current issue
due to the link being replaced with a temporary link, and
the link being related to Mappings API documentation but
does not fully replace the content that the original provided.

Will track replacement with:
#335

Signed-off-by: Kawika Avilla [email protected]

Issues Resolved

Partially: #482

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

Replacing previous upstream reference within the edit index
pattern page. This does not fully resolve the current issue
due to the link being replaced with a temporary link, and
the link being related to Mappings API documentation but
does not fully replace the content that the original provided.

Partially resolves:
opensearch-project#482

Will track replacement with:
opensearch-project#335

Signed-off-by: Kawika Avilla <[email protected]>
@kavilla kavilla added the docs Improvements or additions to documentation label Jun 25, 2021
@kavilla kavilla requested review from tmarkley, boktorbb and ananzh June 25, 2021 17:40
@kavilla
Copy link
Member Author

kavilla commented Jun 25, 2021

Using https://docs-beta.opensearch.org/opensearch/index-templates, let me know if you think we should just use the home page.

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 07e6159

@kavilla kavilla linked an issue Jun 25, 2021 that may be closed by this pull request
Copy link
Member

@ananzh ananzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. thank you rocky

@kavilla kavilla merged commit 65f6773 into opensearch-project:main Jun 26, 2021
kavilla added a commit that referenced this pull request Jun 26, 2021
Replacing previous upstream reference within the edit index
pattern page. This does not fully resolve the current issue
due to the link being replaced with a temporary link, and
the link being related to Mappings API documentation but
does not fully replace the content that the original provided.

Partially resolves:
#482

Will track replacement with:
#335

Signed-off-by: Kawika Avilla <[email protected]>
kavilla added a commit that referenced this pull request Jun 26, 2021
Replacing previous upstream reference within the edit index
pattern page. This does not fully resolve the current issue
due to the link being replaced with a temporary link, and
the link being related to Mappings API documentation but
does not fully replace the content that the original provided.

Partially resolves:
#482

Will track replacement with:
#335

Signed-off-by: Kawika Avilla <[email protected]>
@kavilla kavilla deleted the avillk/bad_link_issue_482 branch June 30, 2021 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Broken link
4 participants