Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [OSCI][FIX] Discover: Fix the Subfields Display Issue #5477

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 40ba1f5 from #5429.

* set flattenHit() deep param as true to allow iterate on nested object

Signed-off-by: Qiwen Li <[email protected]>

---------

Signed-off-by: qiwen li <[email protected]>
Signed-off-by: Qiwen Li <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Anan Zhuang <[email protected]>
Co-authored-by: Miki <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>
(cherry picked from commit 40ba1f5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (63bde3c) 35.26% compared to head (a0754b0) 67.06%.

Additional details and impacted files
@@             Coverage Diff             @@
##              2.x    #5477       +/-   ##
===========================================
+ Coverage   35.26%   67.06%   +31.79%     
===========================================
  Files        1922     3292     +1370     
  Lines       37905    63347    +25442     
  Branches     5454    10063     +4609     
===========================================
+ Hits        13368    42485    +29117     
+ Misses      23922    18421     -5501     
- Partials      615     2441     +1826     
Flag Coverage Δ
Linux_1 35.24% <100.00%> (?)
Linux_2 55.23% <0.00%> (?)
Linux_3 43.89% <100.00%> (?)
Linux_4 35.46% <0.00%> (?)
Windows_1 35.27% <100.00%> (+<0.01%) ⬆️
Windows_2 55.20% <0.00%> (?)
Windows_3 43.89% <100.00%> (?)
Windows_4 35.46% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@manasvinibs manasvinibs merged commit a0a94b2 into 2.x Dec 21, 2023
130 of 131 checks passed
@github-actions github-actions bot deleted the backport/backport-5429-to-2.x branch December 21, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports discover for discover reinvent first-time-contributor v2.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants