Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump chromedriver from 107.0.3 to 119.0.1 #5465

Merged
merged 1 commit into from
Nov 11, 2023

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Nov 10, 2023

Replace PR

#5454

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #5465 (412a686) into main (b82aa1c) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5465   +/-   ##
=======================================
  Coverage   66.96%   66.96%           
=======================================
  Files        3291     3291           
  Lines       63243    63243           
  Branches    10055    10055           
=======================================
  Hits        42349    42349           
  Misses      18453    18453           
  Partials     2441     2441           
Flag Coverage Δ
Linux_1 35.24% <ø> (ø)
Linux_2 55.15% <ø> (ø)
Linux_3 43.81% <ø> (ø)
Linux_4 35.34% <ø> (ø)
Windows_1 35.26% <ø> (ø)
Windows_2 55.12% <ø> (ø)
Windows_3 43.82% <ø> (ø)
Windows_4 35.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ananzh ananzh merged commit 524fd93 into opensearch-project:main Nov 11, 2023
74 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-1.3 1.3
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-1.3
# Create a new branch
git switch --create backport/backport-5465-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 524fd9339d84600e6c351924354e0dade277878e
# Push it to GitHub
git push --set-upstream origin backport/backport-5465-to-1.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-5465-to-1.3.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-5465-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 524fd9339d84600e6c351924354e0dade277878e
# Push it to GitHub
git push --set-upstream origin backport/backport-5465-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-5465-to-2.x.

ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Nov 11, 2023
@ananzh
Copy link
Member Author

ananzh commented Nov 11, 2023

Backport to 1.3 fail analysis

yarn osd bootstrap
yarn run v1.22.19
$ node scripts/osd bootstrap
 info [opensearch-dashboards] running yarn

$ node ./preinstall_check
[1/4] Resolving packages...
warning Resolution field "[email protected]" is incompatible with requested version "typescript@~4.8.4"
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning " > @elastic/[email protected]" has incorrect peer dependency "typescript@^3.7.2".
warning " > @testing-library/[email protected]" has unmet peer dependency "react-test-renderer@>=16.9.0".
[4/4] Building fresh packages...
[14/18] ⡀ fetch-mock
[11/18] ⡀ yo
[8/18] ⡀ puppeteer
[9/18] ⡀ lmdb-store
error /home/ubuntu/work/OpenSearch-Dashboards/node_modules/chromedriver: Command failed.
Exit code: 1
Command: node install.js
Arguments: 
Directory: /home/ubuntu/work/OpenSearch-Dashboards/node_modules/chromedriver
Output:
/home/ubuntu/work/OpenSearch-Dashboards/node_modules/chromedriver/install.js:291
      chromedriverVersion = response.data?.milestones[majorVersion.toString()]?.version;
                                          ^

SyntaxError: Unexpected token .
    at Module._compile (internal/modules/cjs/loader.js:723:23)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)




ERROR [bootstrap] failed:
ERROR Error: Command failed with exit code 1: /home/ubuntu/.nvm/versions/node/v10.24.1/lib/node_modules/yarn/bin/yarn.js install --non-interactive
          at makeError (/home/ubuntu/work/OpenSearch-Dashboards/packages/osd-pm/dist/index.js:25139:11)
          at handlePromise (/home/ubuntu/work/OpenSearch-Dashboards/packages/osd-pm/dist/index.js:24074:26)
          at process._tickCallback (internal/process/next_tick.js:68:7)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

The specific issue seems to be a SyntaxError in chromedriver/install.js. The line causing the error involves optional chaining (?.), which is a relatively new feature in JavaScript. This optional chaining was introduced in Node.js version 14. Due to this conflict, this chromedriver can't be backported to 1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants