[Rename] kbn-test in packages directory to osd-test/#37 [2] #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unner Signed-off-by: Mihir Soni <[email protected]>
Signed-off-by: Mihir Soni <[email protected]>
This was referenced Mar 3, 2021
boktorbb
suggested changes
Mar 4, 2021
Signed-off-by: Mihir Soni <[email protected]>
kavilla
reviewed
Mar 8, 2021
|
|
||
| return ( | ||
| '\n\n' + | ||
| dedent` | ||
| Elasticsearch and Kibana are ready for functional testing. Start the functional tests | ||
| Elasticsearch and Opensearch Dashboards are ready for functional testing. Start the functional tests |
| try { | ||
| es = await runElasticsearch({ config, options: opts }); | ||
| await runKibanaServer({ procs, config, options: opts }); | ||
| opensearch = await runElasticsearch({ config, options: opts }); |
| const caCert = caPath && (await readFile(caPath)); | ||
|
|
||
| for (const { username, password, roles } of updates) { | ||
| // If working with a built-in user, just change the password | ||
| if (['logstash_system', 'elastic', 'kibana'].includes(username)) { | ||
| await updateCredentials({ port: esPort, auth, username, password, protocol, caCert }); | ||
| if (['logstash_system', 'opensearch', 'opensearchDashboards'].includes(username)) { |
There was a problem hiding this comment.
I guess i'm not positive, logstash is still ok to reference? or is it so generic it's fine to leave.
There was a problem hiding this comment.
Agree, let's keep it for now and come back to this later.
Signed-off-by: Mihir Soni <[email protected]>
kavilla
approved these changes
Mar 8, 2021
kavilla
referenced
this pull request
in kavilla/OpenSearch-Dashboards
Mar 19, 2021
…unner #37 [2] (#54) * [Rename] kbn-test in packages directory to osd-test/functional_test_runner Signed-off-by: Mihir Soni <[email protected]> * [Rename] kbn-test in packages directory to osd-test/functional_tests Signed-off-by: Mihir Soni <[email protected]> * [Rename] in-corporate review comments Signed-off-by: Mihir Soni <[email protected]> * [Rename] accomodate PR review feedback Signed-off-by: Mihir Soni <[email protected]>
kavilla
pushed a commit
that referenced
this pull request
Mar 20, 2021
…unner #37 [2] (#54) * [Rename] kbn-test in packages directory to osd-test/functional_test_runner Signed-off-by: Mihir Soni <[email protected]> * [Rename] kbn-test in packages directory to osd-test/functional_tests Signed-off-by: Mihir Soni <[email protected]> * [Rename] in-corporate review comments Signed-off-by: Mihir Soni <[email protected]> * [Rename] accomodate PR review feedback Signed-off-by: Mihir Soni <[email protected]>
mihirsoni
added a commit
that referenced
this pull request
Mar 20, 2021
…unner #37 [2] (#54) * [Rename] kbn-test in packages directory to osd-test/functional_test_runner Signed-off-by: Mihir Soni <[email protected]> * [Rename] kbn-test in packages directory to osd-test/functional_tests Signed-off-by: Mihir Soni <[email protected]> * [Rename] in-corporate review comments Signed-off-by: Mihir Soni <[email protected]> * [Rename] accomodate PR review feedback Signed-off-by: Mihir Soni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #37
Description of changes: Renames inside kbn-test/functional_tests
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.