[Fix] Improve Error Toast Display Content

[willie-hung]

Description

• Remove the "See the full error" button, as error logs should be hidden from users in the frontend.
• Update the error message shown in the error toast.

Issues Resolved

closes #5326

Screenshot

Before

Error Toast

Error Modal

After

Testing the changes

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3c0211b) 66.82% compared to head (7925cbc) 66.97%.
Report is 7 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5345      +/-   ##
==========================================
+ Coverage   66.82%   66.97%   +0.15%     
==========================================
  Files        3291     3291              
  Lines       63174    63223      +49     
  Branches    10055    10052       -3     
==========================================
+ Hits        42213    42342     +129     
+ Misses      18479    18443      -36     
+ Partials     2482     2438      -44     

Flag	Coverage Δ
Linux_1	35.26% <0.00%> (+0.01%)	⬆️
Linux_2	55.16% <100.00%> (-0.13%)	⬇️
Linux_3	43.84% <50.00%> (+0.03%)	⬆️
Linux_4	35.37% <0.00%> (+0.03%)	⬆️
Windows_1	35.28% <0.00%> (+0.02%)	⬆️
Windows_2	55.13% <100.00%> (-0.13%)	⬇️
Windows_3	43.85% <50.00%> (+0.03%)	⬆️
Windows_4	35.37% <0.00%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[willie-hung]

In my view, this line is intended to facilitate easier debugging. It is typically output to the console or saved in a log file and should not be displayed on the frontend. Any ideas for improvement would be appreciated!

[joshuarrrr]

@Willie-The-Lord Can you add a Changelog entry under the bug section?

[bandinib-amzn]

Looks like this change is modifying toast across the entire app (not just Visualization or one plugin). I think we need to evaluate few things as this change affects entire Dashboards.

1. Did we do research on history why See the Full error button has been added in toast? What are the use cases?
2. I agree that it is not right way to see the error but in some extent it helps to debug the issue. If we are removing it, we need to make sure we have enough logs which can help to debug.

Also I would like to hear from @opensearch-project/opensearch-ux how they feel about this change?

[manasvinibs]

Hi @wooonka, Did you get a chance to give a thought to @bandinib-amzn comment here? Also, please resolve the merge conflict caused by changelog file.

[AMoo-Miki]

This is an enhancement; isn't it? Also, we don't need to add [BUG] for bug fixes because they are listed in a section meant for bug fixes.

[ashwin-pc]

I dont think that hiding the "see the full error" button is a good idea :/ As a user im always frustrated when the software tries to hide information from me. We already know that many of OSD's users are technically competent. The See the full error button is a nice way to surface this information without unnecessarily polluting the toast notification

[kgcreative]

I would be open to making "See the full error" a little less prominent, but hiding it all together is not a great experience.

[kavilla]

@bandinib-amzn @kgcreative what is the status on this?

[ananzh]

Convert to draft due to no progress.