Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Data Explorer] Removed X icon in data source selection. #5264

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport df08387 from #5238.

* removed X icon in data source selection.

Signed-off-by: Abhilash <[email protected]>

* updated changelog

Signed-off-by: Abhilash <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Miki <[email protected]>

---------

Signed-off-by: Abhilash <[email protected]>
Signed-off-by: Ashwin P Chandran <[email protected]>
Signed-off-by: Miki <[email protected]>
Co-authored-by: Abhilash <[email protected]>
Co-authored-by: Ashwin P Chandran <[email protected]>
Co-authored-by: Miki <[email protected]>
(cherry picked from commit df08387)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #5264 (d230640) into 2.x (ee243f5) will increase coverage by 0.00%.
Report is 2 commits behind head on 2.x.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              2.x    #5264   +/-   ##
=======================================
  Coverage   66.81%   66.81%           
=======================================
  Files        3284     3284           
  Lines       63146    63146           
  Branches    10047    10047           
=======================================
+ Hits        42192    42193    +1     
+ Misses      18483    18481    -2     
- Partials     2471     2472    +1     
Flag Coverage Δ
Linux_1 35.26% <ø> (ø)
Linux_2 55.26% <ø> (ø)
Linux_3 43.85% <ø> (ø)
Linux_4 35.49% <ø> (-0.01%) ⬇️
Windows_1 35.28% <ø> (ø)
Windows_2 55.23% <ø> (ø)
Windows_3 43.85% <ø> (ø)
Windows_4 35.49% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rces/datasource_selector/datasource_selectable.tsx 64.86% <ø> (ø)

... and 2 files with indirect coverage changes

@ananzh ananzh merged commit cf9a97a into 2.x Oct 10, 2023
76 checks passed
@github-actions github-actions bot deleted the backport/backport-5238-to-2.x branch October 10, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports data explorer Issues related to the Data Explorer project first-time-contributor v2.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants