Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Enable unit test suite: get_cluster_stats.test.ts #525

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Jun 22, 2021

Description

All the unit tests related to unused telemetry are temporarily
skipped after the fork. Unit tests of the disabled telemetry
functions should also be modified correspondingly. To build
a clean unit test, we decide to modify and enable all the
working unit tests. This PR checks and enables
get_cluster_stats.test.ts.

Signed-off-by: Anan Zhuang [email protected]

Issues Resolved

#510

Test results

unit test for get_cluster_stats.test.ts

yarn test:jest /home/anan/work/OpenSearch-Dashboards/src/plugins/telemetry/server/telemetry_collection/get_cluster_stats.test.ts
yarn run v1.22.10
$ node scripts/jest /home/anan/work/OpenSearch-Dashboards/src/plugins/telemetry/server/telemetry_collection/get_cluster_stats.test.ts
 PASS  src/plugins/telemetry/server/telemetry_collection/get_cluster_stats.test.ts
  get_cluster_stats
    ✓ uses the opensearchClient to get the response from the `cluster.stats` API (27 ms)

Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   0 total
Time:        2.676 s

Overall test result:
Screen Shot 2021-06-21 at 8 59 05 PM

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

…project#510)

All the unit tests related to unused telemetry are temporarily
skipped after the fork. Unit tests of the disabled telemetry
functions should also be modified correspondingly. To build
a clean unit test, we decide to modify and enable all the
working unit tests. This PR checks and enables
get_cluster_stats.test.ts.

Signed-off-by: Anan Zhuang <[email protected]>
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 54a3dca

@ananzh ananzh mentioned this pull request Jun 23, 2021
26 tasks
@kavilla kavilla linked an issue Jun 23, 2021 that may be closed by this pull request
@ananzh ananzh merged commit 0707746 into opensearch-project:main Jun 24, 2021
kavilla pushed a commit that referenced this pull request Jun 26, 2021
All the unit tests related to unused telemetry are temporarily
skipped after the fork. Unit tests of the disabled telemetry
functions should also be modified correspondingly. To build
a clean unit test, we decide to modify and enable all the
working unit tests. This PR checks and enables
get_cluster_stats.test.ts.

Signed-off-by: Anan Zhuang <[email protected]>
kavilla pushed a commit that referenced this pull request Jun 26, 2021
All the unit tests related to unused telemetry are temporarily
skipped after the fork. Unit tests of the disabled telemetry
functions should also be modified correspondingly. To build
a clean unit test, we decide to modify and enable all the
working unit tests. This PR checks and enables
get_cluster_stats.test.ts.

Signed-off-by: Anan Zhuang <[email protected]>
@ananzh ananzh deleted the i-510 branch February 23, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Test] unit test get_cluster_stats.test.ts is skipped now
4 participants