[Data Explorer] Add subject test id for testing data-shared-attribute #5196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: abbyhu2000 <[email protected]>
abbyhu2000
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy and
curq
as code owners
ashwin-pc
added
the
Skip-Changelog
ashwin-pc
approved these changes
Oct 4, 2023
Codecov Report
@@ Coverage Diff @@
## main #5196 +/- ##
==========================================
+ Coverage 66.72% 66.76% +0.03%
==========================================
Files 3278 3278
Lines 62999 62999
Branches 10031 10031
==========================================
+ Hits 42037 42059 +22
+ Misses 18571 18473 -98
- Partials 2391 2467 +76
Flags with carried forward coverage won't be shown. Click here to find out more. |
kavilla
approved these changes
Oct 4, 2023
| @@ -176,6 +176,7 @@ export const DataGridTable = ({ | |||
| data-shared-item="" | |||
| data-title={title} | |||
| data-description={description} | |||
| data-test-subj="discoverTable" | |||
There was a problem hiding this comment.
nice, heads-up fixing. issue with PRs that i'm fixing.
not a blocker for this PR.
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-5196-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3024c6a8afbd3e19529bb660ee176b3862296742
# Push it to GitHub
git push --set-upstream origin backport/backport-5196-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.xThen, create a pull request where the |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 4, 2023
Signed-off-by: abbyhu2000 <[email protected]> (cherry picked from commit 3024c6a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kavilla
pushed a commit
that referenced
this pull request
Oct 4, 2023
(cherry picked from commit 3024c6a) Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
willie-hung
pushed a commit
to willie-hung/OpenSearch-Dashboards
that referenced
this pull request
Oct 5, 2023
…ject#5196) Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: Willie Hung <[email protected]>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Oct 7, 2023
…ject#5196) Signed-off-by: abbyhu2000 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a subject test id for testing
data-shared-attributefor the discover table.