Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Data Explorer][Discover] Fix total hits issue for no time based data #5093

Merged
merged 3 commits into from
Sep 26, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport a10f1c7 from #5087.

Issue Resolve
#5068

Signed-off-by: ananzh <[email protected]>
(cherry picked from commit a10f1c7)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@opensearch-trigger-bot opensearch-trigger-bot bot added bug Something isn't working discover for discover reinvent labels Sep 22, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot added de-angular de-angularize work autocut Skip the changelog verification check on backports distinguished-contributor data explorer Issues related to the Data Explorer project v2.11.0 labels Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #5093 (0f5bcf9) into 2.x (5a049c9) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              2.x    #5093      +/-   ##
==========================================
- Coverage   66.47%   66.46%   -0.02%     
==========================================
  Files        3402     3402              
  Lines       64982    64982              
  Branches    10374    10374              
==========================================
- Hits        43199    43190       -9     
- Misses      19219    19228       +9     
  Partials     2564     2564              
Flag Coverage Δ
Linux_1 34.87% <ø> (ø)
Linux_2 55.19% <ø> (ø)
Linux_3 44.38% <ø> (?)
Linux_4 35.05% <ø> (ø)
Windows_1 ?
Windows_2 55.15% <ø> (ø)
Windows_3 44.38% <ø> (ø)
Windows_4 35.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@abbyhu2000 abbyhu2000 merged commit 7ae32d6 into 2.x Sep 26, 2023
53 checks passed
@github-actions github-actions bot deleted the backport/backport-5087-to-2.x branch September 26, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports bug Something isn't working data explorer Issues related to the Data Explorer project de-angular de-angularize work discover for discover reinvent distinguished-contributor v2.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants