Modifying html fixtures to utilize jsx and fixing tests to include all p… #5080

zashary · 2023-09-20T23:42:58Z

Description

Doc cleanup for i18n angular removal
Convert html fixtures to jsx
Check all pluginPaths for message extraction

Issues Resolved

[I18n De-Angular] Remove angular-related parts of OpenSearch Dashboards i18n system #4018 Convert html to jsx and doc updates
[De-Angular][I18n] Remaining cleaning work on I18n package #5018 Removes osd/i18n/angular from shared deps
Modifies the check for all plugin paths to include all plugins, instead of first of the array.

Check List

codecov · 2023-09-21T00:01:18Z

Codecov Report

Merging #5080 (512faa9) into feature/deangular (8221fea) will increase coverage by 0.00%.
Report is 2 commits behind head on feature/deangular.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##           feature/deangular    #5080   +/-   ##
==================================================
  Coverage              66.69%   66.69%           
==================================================
  Files                   3283     3283           
  Lines                  63059    63059           
  Branches               10031    10031           
==================================================
+ Hits                   42056    42058    +2     
+ Misses                 18537    18536    -1     
+ Partials                2466     2465    -1

Flag	Coverage Δ
Linux_1	`35.25% <ø> (ø)`
Linux_2	`55.23% <ø> (ø)`
Linux_3	`43.66% <ø> (ø)`
Linux_4	`35.43% <ø> (ø)`
Windows_1	`35.27% <ø> (ø)`
Windows_2	`55.20% <ø> (ø)`
Windows_3	`43.67% <ø> (+<0.01%)`	⬆️
Windows_4	`35.43% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

ashwin-pc

@zashary Thanks for the changes, they look good to me. Also really nice job updating the Readme's too.

ashwin-pc · 2023-09-21T00:13:50Z

CI will fail for the functional tests, this isnt because of the PR, but rather the target branch.

ananzh

LGTM. thx.

ananzh · 2023-09-21T23:06:26Z

src/dev/i18n/__fixtures__/extract_default_translations/test_plugin_4/test_file_4.jsx

@@ -0,0 +1,14 @@
+/* eslint-disable */


missing license?

/* * Copyright OpenSearch Contributors * SPDX-License-Identifier: Apache-2.0 */

ananzh · 2023-09-21T23:06:39Z

src/dev/i18n/__fixtures__/extract_default_translations/test_plugin_2/test_file.jsx

@@ -0,0 +1,12 @@
+/*


should the license be

/* * Copyright OpenSearch Contributors * SPDX-License-Identifier: Apache-2.0 */

Good catches! I am not sure. I grabbed the license from: https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/dev/i18n/__fixtures__/extract_default_translations/test_plugin_1/test_file_1.jsx#L1-L10

Do we have a standard that should be used?

EsLint should automatically add this for you if you have it configured correctly in your editor. But to answer your question, the License @ananzh provided is the standard :)

ananzh · 2023-09-21T23:10:25Z

@ashwin-pc do we need license for these data file? or should we just remove all? I am okay with either but want them to be consistent.

ashwin-pc · 2023-09-21T23:13:53Z

@ananzh good catch, yes we do need to add the license header, surprised that the linter didnt catch these

…luginPaths Signed-off-by: Zashary Maskus-Lavin <[email protected]>

* Basic working version of OSD without angular (#4982) Signed-off-by: Ashwin P Chandran <[email protected]> * [Data Explorer][Discover 2.0] Implement saved search embeddable (#5081) * [Data Explorer][Discover 2.0] Implement saved search embeddable Issue Resolve #4233 --------- Signed-off-by: ananzh <[email protected]> * Deangular: removes angular paginate, cleanup data plugin and tilemap (#5060) Signed-off-by: Ashwin P Chandran <[email protected]> * [Data Explorer] Delete legacy discover selenium tests (#5088) * delete legacy discover functional tests Signed-off-by: abbyhu2000 <[email protected]> * remove discover folder in config file Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * [Data Explorer][Discover][Function Test] Fix ciGroup4 (#5099) * add data-render-complete and data-shared-item for test convenience * change docTableFieldCount to dataGridTableCellCount to fetch data grid cell * add methods in data grid service to reuse current massive selenium tests * update tests Issue Resolve #5098 #5058 Signed-off-by: Anan Zhuang <[email protected]> * [Data Explorer][Discover][Functional Test] fix ciGroup 8 (#5104) Update index pattern fetch method in discover page due to changing to EuiComboBox. Issue Resolve #5103 Signed-off-by: Anan Zhuang <[email protected]> * Fix cigroup 1 with dataGridTable helper functions (#5105) * fix1 Signed-off-by: abbyhu2000 <[email protected]> * fix 1 Signed-off-by: abbyhu2000 <[email protected]> * fix anchor test Signed-off-by: abbyhu2000 <[email protected]> * fix cigroup1 Signed-off-by: abbyhu2000 <[email protected]> * address comments Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * [Data Explorer] Fix functional cigroup 3 for save search on dashboard filtering (#5111) * fix cigroup3 Signed-off-by: abbyhu2000 <[email protected]> * fix error Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * add data-shared-item tag (#5119) Signed-off-by: abbyhu2000 <[email protected]> * Modifying html tests to utilize jsx and fixing tests to include all pluginPaths (#5080) Signed-off-by: Zashary Maskus-Lavin <[email protected]> * fix cigroup6 (#5125) Signed-off-by: abbyhu2000 <[email protected]> * [Discover] Search on load fix (#5112) * fixes search on load Signed-off-by: Ashwin P Chandran <[email protected]> * Fixes search after initial page load Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> * [Data Explorer][Discover][Functional Test] Fix ciGroup7 (#5131) * [Data Explorer][Discover][Functional Test] Fix ciGroup7 Issue Resolve #5129 Signed-off-by: Anan Zhuang <[email protected]> * restore _discover_navigation Signed-off-by: Anan Zhuang <[email protected]> --------- Signed-off-by: Anan Zhuang <[email protected]> * Deangular: removes angular from notify and utils of opendashboards legacy (#5085) * Basic working version of OSD without angular (#4982) Signed-off-by: Ashwin P Chandran <[email protected]> * deangularized notify and utils folders in the opendashboards legacy directory Signed-off-by: Cameron Reed <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Cameron Reed <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> Co-authored-by: Cameron Reed <[email protected]> * [Discover] Misc fixes (#5114) * Canvas scrolling fix, remove notice and improve flyout focus Signed-off-by: Ashwin P Chandran <[email protected]> * Hide action icons unless hovered or focussed on Signed-off-by: Ashwin P Chandran <[email protected]> * followup fixes from #5085 Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: ananzh <[email protected]> Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Zashary Maskus-Lavin <[email protected]> Signed-off-by: Cameron Reed <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Qingyang(Abby) Hu <[email protected]> Co-authored-by: Zashary Maskus-Lavin <[email protected]> Co-authored-by: Cameron Reed <[email protected]> Co-authored-by: Cameron Reed <[email protected]>

* Basic working version of OSD without angular (opensearch-project#4982) Signed-off-by: Ashwin P Chandran <[email protected]> * [Data Explorer][Discover 2.0] Implement saved search embeddable (opensearch-project#5081) * [Data Explorer][Discover 2.0] Implement saved search embeddable Issue Resolve opensearch-project#4233 --------- Signed-off-by: ananzh <[email protected]> * Deangular: removes angular paginate, cleanup data plugin and tilemap (opensearch-project#5060) Signed-off-by: Ashwin P Chandran <[email protected]> * [Data Explorer] Delete legacy discover selenium tests (opensearch-project#5088) * delete legacy discover functional tests Signed-off-by: abbyhu2000 <[email protected]> * remove discover folder in config file Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * [Data Explorer][Discover][Function Test] Fix ciGroup4 (opensearch-project#5099) * add data-render-complete and data-shared-item for test convenience * change docTableFieldCount to dataGridTableCellCount to fetch data grid cell * add methods in data grid service to reuse current massive selenium tests * update tests Issue Resolve opensearch-project#5098 opensearch-project#5058 Signed-off-by: Anan Zhuang <[email protected]> * [Data Explorer][Discover][Functional Test] fix ciGroup 8 (opensearch-project#5104) Update index pattern fetch method in discover page due to changing to EuiComboBox. Issue Resolve opensearch-project#5103 Signed-off-by: Anan Zhuang <[email protected]> * Fix cigroup 1 with dataGridTable helper functions (opensearch-project#5105) * fix1 Signed-off-by: abbyhu2000 <[email protected]> * fix 1 Signed-off-by: abbyhu2000 <[email protected]> * fix anchor test Signed-off-by: abbyhu2000 <[email protected]> * fix cigroup1 Signed-off-by: abbyhu2000 <[email protected]> * address comments Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * [Data Explorer] Fix functional cigroup 3 for save search on dashboard filtering (opensearch-project#5111) * fix cigroup3 Signed-off-by: abbyhu2000 <[email protected]> * fix error Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * add data-shared-item tag (opensearch-project#5119) Signed-off-by: abbyhu2000 <[email protected]> * Modifying html tests to utilize jsx and fixing tests to include all pluginPaths (opensearch-project#5080) Signed-off-by: Zashary Maskus-Lavin <[email protected]> * fix cigroup6 (opensearch-project#5125) Signed-off-by: abbyhu2000 <[email protected]> * [Discover] Search on load fix (opensearch-project#5112) * fixes search on load Signed-off-by: Ashwin P Chandran <[email protected]> * Fixes search after initial page load Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> * [Data Explorer][Discover][Functional Test] Fix ciGroup7 (opensearch-project#5131) * [Data Explorer][Discover][Functional Test] Fix ciGroup7 Issue Resolve opensearch-project#5129 Signed-off-by: Anan Zhuang <[email protected]> * restore _discover_navigation Signed-off-by: Anan Zhuang <[email protected]> --------- Signed-off-by: Anan Zhuang <[email protected]> * Deangular: removes angular from notify and utils of opendashboards legacy (opensearch-project#5085) * Basic working version of OSD without angular (opensearch-project#4982) Signed-off-by: Ashwin P Chandran <[email protected]> * deangularized notify and utils folders in the opendashboards legacy directory Signed-off-by: Cameron Reed <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Cameron Reed <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> Co-authored-by: Cameron Reed <[email protected]> * [Discover] Misc fixes (opensearch-project#5114) * Canvas scrolling fix, remove notice and improve flyout focus Signed-off-by: Ashwin P Chandran <[email protected]> * Hide action icons unless hovered or focussed on Signed-off-by: Ashwin P Chandran <[email protected]> * followup fixes from opensearch-project#5085 Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: ananzh <[email protected]> Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Zashary Maskus-Lavin <[email protected]> Signed-off-by: Cameron Reed <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Qingyang(Abby) Hu <[email protected]> Co-authored-by: Zashary Maskus-Lavin <[email protected]> Co-authored-by: Cameron Reed <[email protected]> Co-authored-by: Cameron Reed <[email protected]> (cherry picked from commit 0557ab1) Signed-off-by: Ashwin P Chandran <[email protected]>

* [Deangular] OSD without angular (#5086) * Basic working version of OSD without angular (#4982) Signed-off-by: Ashwin P Chandran <[email protected]> * [Data Explorer][Discover 2.0] Implement saved search embeddable (#5081) * [Data Explorer][Discover 2.0] Implement saved search embeddable Issue Resolve #4233 --------- Signed-off-by: ananzh <[email protected]> * Deangular: removes angular paginate, cleanup data plugin and tilemap (#5060) Signed-off-by: Ashwin P Chandran <[email protected]> * [Data Explorer] Delete legacy discover selenium tests (#5088) * delete legacy discover functional tests Signed-off-by: abbyhu2000 <[email protected]> * remove discover folder in config file Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * [Data Explorer][Discover][Function Test] Fix ciGroup4 (#5099) * add data-render-complete and data-shared-item for test convenience * change docTableFieldCount to dataGridTableCellCount to fetch data grid cell * add methods in data grid service to reuse current massive selenium tests * update tests Issue Resolve #5098 #5058 Signed-off-by: Anan Zhuang <[email protected]> * [Data Explorer][Discover][Functional Test] fix ciGroup 8 (#5104) Update index pattern fetch method in discover page due to changing to EuiComboBox. Issue Resolve #5103 Signed-off-by: Anan Zhuang <[email protected]> * Fix cigroup 1 with dataGridTable helper functions (#5105) * fix1 Signed-off-by: abbyhu2000 <[email protected]> * fix 1 Signed-off-by: abbyhu2000 <[email protected]> * fix anchor test Signed-off-by: abbyhu2000 <[email protected]> * fix cigroup1 Signed-off-by: abbyhu2000 <[email protected]> * address comments Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * [Data Explorer] Fix functional cigroup 3 for save search on dashboard filtering (#5111) * fix cigroup3 Signed-off-by: abbyhu2000 <[email protected]> * fix error Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * add data-shared-item tag (#5119) Signed-off-by: abbyhu2000 <[email protected]> * Modifying html tests to utilize jsx and fixing tests to include all pluginPaths (#5080) Signed-off-by: Zashary Maskus-Lavin <[email protected]> * fix cigroup6 (#5125) Signed-off-by: abbyhu2000 <[email protected]> * [Discover] Search on load fix (#5112) * fixes search on load Signed-off-by: Ashwin P Chandran <[email protected]> * Fixes search after initial page load Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> * [Data Explorer][Discover][Functional Test] Fix ciGroup7 (#5131) * [Data Explorer][Discover][Functional Test] Fix ciGroup7 Issue Resolve #5129 Signed-off-by: Anan Zhuang <[email protected]> * restore _discover_navigation Signed-off-by: Anan Zhuang <[email protected]> --------- Signed-off-by: Anan Zhuang <[email protected]> * Deangular: removes angular from notify and utils of opendashboards legacy (#5085) * Basic working version of OSD without angular (#4982) Signed-off-by: Ashwin P Chandran <[email protected]> * deangularized notify and utils folders in the opendashboards legacy directory Signed-off-by: Cameron Reed <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Cameron Reed <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> Co-authored-by: Cameron Reed <[email protected]> * [Discover] Misc fixes (#5114) * Canvas scrolling fix, remove notice and improve flyout focus Signed-off-by: Ashwin P Chandran <[email protected]> * Hide action icons unless hovered or focussed on Signed-off-by: Ashwin P Chandran <[email protected]> * followup fixes from #5085 Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: ananzh <[email protected]> Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Zashary Maskus-Lavin <[email protected]> Signed-off-by: Cameron Reed <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Qingyang(Abby) Hu <[email protected]> Co-authored-by: Zashary Maskus-Lavin <[email protected]> Co-authored-by: Cameron Reed <[email protected]> Co-authored-by: Cameron Reed <[email protected]> (cherry picked from commit 0557ab1) Signed-off-by: Ashwin P Chandran <[email protected]> * fixes snapshot Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: ananzh <[email protected]> Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Zashary Maskus-Lavin <[email protected]> Signed-off-by: Cameron Reed <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Qingyang(Abby) Hu <[email protected]> Co-authored-by: Zashary Maskus-Lavin <[email protected]> Co-authored-by: Cameron Reed <[email protected]> Co-authored-by: Cameron Reed <[email protected]>

zashary requested review from ananzh, kavilla, seanneumann, AMoo-Miki, ashwin-pc, joshuarrrr, abbyhu2000, zengyan-amazon, kristenTian, zhongnansu, manasvinibs, ZilongX, Flyingliuhub, BSFishy and curq as code owners September 20, 2023 23:42

github-actions bot added the first-time-contributor label Sep 20, 2023

zashary force-pushed the 4018 branch 2 times, most recently from d466106 to a1bd9fa Compare September 20, 2023 23:46

ashwin-pc added the de-angular de-angularize work label Sep 21, 2023

ashwin-pc approved these changes Sep 21, 2023

View reviewed changes

zashary force-pushed the 4018 branch from a1bd9fa to 95ca191 Compare September 21, 2023 00:12

ananzh approved these changes Sep 21, 2023

View reviewed changes

ananzh reviewed Sep 21, 2023

View reviewed changes

ananzh requested review from ananzh and ashwin-pc September 21, 2023 23:07

zashary force-pushed the 4018 branch from 95ca191 to 3f9f005 Compare September 22, 2023 20:12

ananzh approved these changes Sep 22, 2023

View reviewed changes

abbyhu2000 force-pushed the feature/deangular branch from f14c199 to e6b9ab2 Compare September 22, 2023 22:54

zashary force-pushed the 4018 branch 3 times, most recently from b760729 to a418c79 Compare September 25, 2023 21:16

Modifying html tests to utilize jsx and fixing tests to include all p…

512faa9

…luginPaths Signed-off-by: Zashary Maskus-Lavin <[email protected]>

zashary force-pushed the 4018 branch from a418c79 to 512faa9 Compare September 25, 2023 21:19

ashwin-pc approved these changes Sep 26, 2023

View reviewed changes

ashwin-pc merged commit 7a843e6 into opensearch-project:feature/deangular Sep 26, 2023
41 of 52 checks passed

ashwin-pc mentioned this pull request Sep 27, 2023

[De-Anagular] Clean/Modify documents #5017

Closed

4 tasks

ashwin-pc mentioned this pull request Oct 3, 2023

[Manual backport 2.x][Deangular] OSD without angular (#5086) #5177

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modifying html fixtures to utilize jsx and fixing tests to include all p… #5080

Modifying html fixtures to utilize jsx and fixing tests to include all p… #5080

zashary commented Sep 20, 2023 •

edited by ashwin-pc

Loading

codecov bot commented Sep 21, 2023 •

edited

Loading

ashwin-pc left a comment

ashwin-pc commented Sep 21, 2023

ananzh left a comment

ananzh Sep 21, 2023

ananzh Sep 21, 2023

zashary Sep 21, 2023

ashwin-pc Sep 26, 2023

ananzh commented Sep 21, 2023

ashwin-pc commented Sep 21, 2023

Modifying html fixtures to utilize jsx and fixing tests to include all p… #5080

Modifying html fixtures to utilize jsx and fixing tests to include all p… #5080

Conversation

zashary commented Sep 20, 2023 • edited by ashwin-pc Loading

Description

Issues Resolved

Check List

codecov bot commented Sep 21, 2023 • edited Loading

Codecov Report

ashwin-pc left a comment

Choose a reason for hiding this comment

ashwin-pc commented Sep 21, 2023

ananzh left a comment

Choose a reason for hiding this comment

ananzh Sep 21, 2023

Choose a reason for hiding this comment

ananzh Sep 21, 2023

Choose a reason for hiding this comment

zashary Sep 21, 2023

Choose a reason for hiding this comment

ashwin-pc Sep 26, 2023

Choose a reason for hiding this comment

ananzh commented Sep 21, 2023

ashwin-pc commented Sep 21, 2023

zashary commented Sep 20, 2023 •

edited by ashwin-pc

Loading

codecov bot commented Sep 21, 2023 •

edited

Loading