Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating yarn installation step from the Dev guide #5065

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

dtaivpp
Copy link
Contributor

@dtaivpp dtaivpp commented Sep 19, 2023

Description

Fixes issue with yarn install step in developer guides

Issues Resolved

N/A

Screenshot

N/A

Testing the changes

@cwperks and I had run through the developer guide end to end and ran into issues with the current step but re-running with npm i -g yarn worked to install the right version of yarn so the dependencies could be installed.

Check List

  • Commits are signed per the DCO using --signoff

@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-1.3 1.3
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-1.3
# Create a new branch
git switch --create backport/backport-5065-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f02a88ec18168d3baf8b762f8f246424d776aa0c
# Push it to GitHub
git push --set-upstream origin backport/backport-5065-to-1.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-5065-to-1.3.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-5065-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f02a88ec18168d3baf8b762f8f246424d776aa0c
# Push it to GitHub
git push --set-upstream origin backport/backport-5065-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-5065-to-2.x.

@joshuarrrr joshuarrrr added not in release PRs backported to already shipped releases with no future release planned and removed backport 2.x failed backport v2.11.0 v1.3.14 labels Sep 19, 2023
@joshuarrrr
Copy link
Member

skipping backports in favor of #5067

SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time-contributor not in release PRs backported to already shipped releases with no future release planned Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants