Bump node-sass to address LibSass vulnerabilities #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ DCO Check Passed 4c795fb |
There are a few known security vulnerabilities related to the version of node-sass used in the repo. Both node-sass and LibSass are deprecated, but replacing node-sass with dart-sass fails because EUI does not follow the standard Sass spec. This results in a SassError: `Top-level selectors may not contain the parent selector "&"`. Resolving this problem will have to be done in the long-term, but for now there are branches of node-sass that exist with a newer version of LibSass that does not contain any known security vulnerabilities. Unfortunately, these changes don't exist in any of the main releases, so we must use a specific branch (v5). Details are on the main Sass website: https://sass-lang.com/blog/libsass-is-deprecated Signed-off-by: Tommy Markley <[email protected]>
|
✅ DCO Check Passed 24b02f9 |
|
All tests are passing after rebasing.
|
ananzh
approved these changes
Jun 22, 2021
kavilla
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are a few known security vulnerabilities related to the version of node-sass used in the repo. Both node-sass and LibSass are deprecated, but replacing node-sass with dart-sass fails because EUI does not follow the standard Sass spec. This results in a SassError:
Top-level selectors may not contain the parent selector "&". Resolving this problem will have to be done in the long-term, but for now there are branches of node-sass that exist with a newer version of LibSass that does not contain any known security vulnerabilities. Unfortunately, these changes don't exist in any of the main releases, so we must use a specific branch (v5).Details are on the main Sass website: https://sass-lang.com/blog/libsass-is-deprecated
Node-sass Issue for LibSass 3.6: sass/node-sass#2685
node-sass v5 branch: https://github.com/sass/node-sass/tree/v5
Signed-off-by: Tommy Markley [email protected]
Issues Resolved
N/A
Testing
Check List