Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.10] [Manual Backport 2.x][Console] Add support for JSON with long numerals (#4562) #4973

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport e69d38d from #4967.

Also:
* Add support for parsing and stringifying JSON with long numerals into `@osd/std`
* Upgrade to `@opensearch/[email protected]` which supports long numerals
* Add support for long numerals to `http/fetch`

Signed-off-by: Miki <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Co-authored-by: Miki <[email protected]>
(cherry picked from commit e69d38d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #4973 (fd4ce6a) into 2.10 (d1400d6) will increase coverage by 0.06%.
The diff coverage is 92.03%.

@@            Coverage Diff             @@
##             2.10    #4973      +/-   ##
==========================================
+ Coverage   66.44%   66.50%   +0.06%     
==========================================
  Files        3399     3400       +1     
  Lines       64881    64981     +100     
  Branches    10360    10385      +25     
==========================================
+ Hits        43107    43215     +108     
+ Misses      19215    19210       -5     
+ Partials     2559     2556       -3     
Flag Coverage Δ
Linux_1 34.82% <15.46%> (-0.05%) ⬇️
Linux_2 55.34% <92.00%> (+0.14%) ⬆️
Linux_3 44.47% <66.37%> (+0.22%) ⬆️
Linux_4 35.02% <26.47%> (-0.03%) ⬇️
Windows_1 34.83% <15.46%> (-0.05%) ⬇️
Windows_2 55.30% <92.00%> (+0.15%) ⬆️
Windows_3 44.47% <66.37%> (+0.22%) ⬆️
Windows_4 35.02% <26.47%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/core/server/opensearch/client/mocks.ts 98.21% <ø> (ø)
...lugins/console/public/lib/opensearch/opensearch.ts 75.00% <ø> (ø)
src/plugins/console/public/services/storage.ts 0.00% <0.00%> (ø)
.../server/routes/api/console/proxy/create_handler.ts 67.39% <40.00%> (-2.38%) ⬇️
packages/osd-std/src/json.ts 95.74% <95.74%> (ø)
packages/osd-std/src/index.ts 100.00% <100.00%> (ø)
src/core/public/http/fetch.ts 96.05% <100.00%> (ø)
...rc/core/server/opensearch/client/cluster_client.ts 85.71% <100.00%> (+1.50%) ⬆️
...equest_to_opensearch/send_request_to_opensearch.ts 70.49% <100.00%> (ø)
src/plugins/console/public/lib/utils/index.ts 86.04% <100.00%> (+27.90%) ⬆️
... and 1 more

... and 5 files with indirect coverage changes

📢 Have feedback on the report? Share it here.

@joshuarrrr joshuarrrr merged commit e3cebe7 into 2.10 Sep 8, 2023
70 of 71 checks passed
@github-actions github-actions bot deleted the backport/backport-4967-to-2.10 branch September 8, 2023 21:16
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this pull request Sep 8, 2023
kavilla added a commit that referenced this pull request Sep 8, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 8, 2023
) (#4973)" (#4977)

This reverts commit e3cebe7.

Signed-off-by: Kawika Avilla <[email protected]>
(cherry picked from commit b75edfa)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
manasvinibs pushed a commit that referenced this pull request Sep 11, 2023
) (#4973)" (#4977) (#4978)

This reverts commit e3cebe7.


(cherry picked from commit b75edfa)

Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants