[Backport 2.x] Fix (discover): Fix dismiss callout and next styling #4951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Fix (discover): Fix dismiss callout and next styling 1. Fix `onDismiss` prop of callout 2. Put callout in panel for better alignment in discover 3. Add `subdued` to combobox panel 4. Use `primary`-derived color for field titles in discover (and lint-ignore) Signed-off-by: Josh Romero <[email protected]> * Update index.tsx fix conflict * fix linting indentation Signed-off-by: Josh Romero <[email protected]> * update snapshot Signed-off-by: Josh Romero <[email protected]> --------- Signed-off-by: Josh Romero <[email protected]> (cherry picked from commit d3388c5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
seanneumann and
AMoo-Miki
as code owners
opensearch-trigger-bot
bot
added
discover
opensearch-trigger-bot
bot
requested a review
from ashwin-pc
as a code owner
opensearch-trigger-bot
bot
added
the
autocut
opensearch-trigger-bot
bot
requested a review
from joshuarrrr
as a code owner
opensearch-trigger-bot
bot
added
Skip-Changelog
opensearch-trigger-bot
bot
requested a review
from abbyhu2000
as a code owner
opensearch-trigger-bot
bot
added
the
data explorer
opensearch-trigger-bot
bot
requested a review
from zengyan-amazon
as a code owner
opensearch-trigger-bot
bot
requested review from
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub and
BSFishy
as code owners
AMoo-Miki
approved these changes
Sep 6, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #4951 +/- ##
=======================================
Coverage 66.44% 66.44%
=======================================
Files 3399 3399
Lines 64881 64881
Branches 10360 10360
=======================================
+ Hits 43107 43109 +2
+ Misses 19215 19214 -1
+ Partials 2559 2558 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
joshuarrrr
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport d3388c5 from #4938.