Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Datasource Support #4931

Conversation

mengweieric
Copy link
Collaborator

@mengweieric mengweieric commented Sep 5, 2023

Description

Draft PR for adding datasource selector

Issues Resolved

#4482 #4991

Screenshot

[will attach]

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #4931 (a1338b9) into main (46d7c2d) will decrease coverage by 0.07%.
Report is 1 commits behind head on main.
The diff coverage is 8.91%.

@@            Coverage Diff             @@
##             main    #4931      +/-   ##
==========================================
- Coverage   66.50%   66.44%   -0.07%     
==========================================
  Files        3403     3409       +6     
  Lines       65026    65093      +67     
  Branches    10401    10410       +9     
==========================================
+ Hits        43243    43248       +5     
- Misses      19214    19275      +61     
- Partials     2569     2570       +1     
Flag Coverage Δ
Linux_1 ?
Linux_2 55.31% <ø> (ø)
Linux_3 44.55% <10.00%> (-0.05%) ⬇️
Linux_4 34.83% <2.89%> (-0.07%) ⬇️
Windows_1 34.77% <6.02%> (-0.07%) ⬇️
Windows_2 55.27% <ø> (ø)
Windows_3 44.56% <10.00%> (-0.05%) ⬇️
Windows_4 34.83% <2.89%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ources/datasource_selector/datasource_selector.tsx 100.00% <100.00%> (ø)
src/plugins/data/public/index.ts 85.71% <ø> (ø)
src/plugins/discover/common/index.ts 100.00% <100.00%> (ø)
src/plugins/data/public/plugin.ts 0.00% <0.00%> (ø)
.../data/public/data_sources/datasource/datasource.ts 0.00% <0.00%> (ø)
...a/public/data_sources/datasource_services/types.ts 0.00% <0.00%> (ø)
src/plugins/discover/public/plugin.ts 0.00% <0.00%> (ø)
.../discover/public/datasources/default_datasource.ts 0.00% <0.00%> (ø)
...ins/data/public/data_sources/datasource/factory.ts 0.00% <0.00%> (ø)
.../data_explorer/public/components/sidebar/index.tsx 3.44% <0.00%> (+0.32%) ⬆️
... and 2 more

... and 4 files with indirect coverage changes

@mengweieric mengweieric changed the title Feature/datasource selector Multiple Datasource Support Sep 19, 2023
@mengweieric mengweieric force-pushed the feature/datasource-selector branch 3 times, most recently from 249f139 to f5eb41b Compare September 22, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant