Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Vis Colors] Update color mapper to prioritize unique colors per vis #4898

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport abcef34 from #4890.

…4890)

* [Vis Colors] Update color mapper to prioritize unique colors per vis

Instead of trying to generate unique colors for an entire dashboard

Signed-off-by: Josh Romero <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Josh Romero <[email protected]>

---------

Signed-off-by: Josh Romero <[email protected]>
(cherry picked from commit abcef34)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #4898 (a11dd67) into 2.x (993ebc0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              2.x    #4898   +/-   ##
=======================================
  Coverage   66.44%   66.44%           
=======================================
  Files        3398     3398           
  Lines       64870    64871    +1     
  Branches    10358    10358           
=======================================
+ Hits        43100    43102    +2     
+ Misses      19212    19211    -1     
  Partials     2558     2558           
Flag Coverage Δ
Linux_1 34.91% <33.33%> (-0.01%) ⬇️
Linux_2 55.18% <ø> (ø)
Linux_3 44.20% <100.00%> (+<0.01%) ⬆️
Linux_4 35.09% <0.00%> (-0.01%) ⬇️
Windows_1 34.92% <33.33%> (-0.01%) ⬇️
Windows_2 55.15% <ø> (ø)
Windows_3 44.20% <100.00%> (+<0.01%) ⬆️
Windows_4 35.09% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...rc/plugins/charts/public/services/colors/colors.ts 100.00% <ø> (ø)
...ins/charts/public/services/colors/mapped_colors.ts 96.42% <100.00%> (+3.83%) ⬆️

@joshuarrrr joshuarrrr merged commit 318c537 into 2.x Sep 1, 2023
@joshuarrrr joshuarrrr deleted the backport/backport-4890-to-2.x branch September 1, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports distinguished-contributor v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants