[Backport 2.x] Change color fn used to calculate icon colors for search typeahead #4886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…ggestions (#4884) Icons don't need to be as high contrast as text, so the 3:1 threshold of `makeGraphicContrastColor` is more appropriate Signed-off-by: Josh Romero <[email protected]> (cherry picked from commit b24f33a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
seanneumann and
AMoo-Miki
as code owners
opensearch-trigger-bot
bot
added
autocut
opensearch-trigger-bot
bot
requested review from
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub and
BSFishy
as code owners
Codecov Report
@@ Coverage Diff @@
## 2.x #4886 +/- ##
==========================================
- Coverage 66.44% 66.44% -0.01%
==========================================
Files 3396 3396
Lines 64847 64847
Branches 10356 10356
==========================================
- Hits 43088 43086 -2
- Misses 19202 19203 +1
- Partials 2557 2558 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
joshuarrrr
approved these changes
Sep 1, 2023
kavilla
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport b24f33a from #4884.