[Backport 2.x] [Data Explorer][Discover 2.0] Fix issues when change index pattern #4885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…4875) * allow side nav show only selected index pattern fields when switch * allow reset column state when switch index pattern Issue Resolve: #4840 #4846 Signed-off-by: ananzh <[email protected]> (cherry picked from commit 9958799) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc and
joshuarrrr
as code owners
opensearch-trigger-bot
bot
added
discover
opensearch-trigger-bot
bot
added
Skip-Changelog
opensearch-trigger-bot
bot
requested a review
from zengyan-amazon
as a code owner
opensearch-trigger-bot
bot
added
the
data explorer
opensearch-trigger-bot
bot
requested a review
from kristenTian
as a code owner
opensearch-trigger-bot
bot
requested review from
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub and
BSFishy
as code owners
Codecov Report
@@ Coverage Diff @@
## 2.x #4885 +/- ##
=======================================
Coverage 66.44% 66.44%
=======================================
Files 3396 3397 +1
Lines 64847 64850 +3
Branches 10356 10357 +1
=======================================
+ Hits 43088 43091 +3
Misses 19202 19202
Partials 2557 2557
Flags with carried forward coverage won't be shown. Click here to find out more.
|
joshuarrrr
approved these changes
Sep 1, 2023
AMoo-Miki
approved these changes
Sep 1, 2023
MadaniKK
added a commit
to MadaniKK/OpenSearch-Dashboards
that referenced
this pull request
Nov 18, 2023
…ttern (opensearch-project#4875) (opensearch-project#4885)" This reverts commit 0102a32. try revert:
ashwin-pc
added a commit
that referenced
this pull request
Dec 21, 2023
…CH (#5508) * Revert "[Data Explorer][Discover 2.0] Fix issues when change index pattern (#4875) (#4885)" This reverts commit 0102a32. try revert: * [osci23] implmented advance setting in Dicover: MODIFY_COLUMN_ON_SWITCH Signed-off-by: qiwen li <[email protected]> * fix deps Signed-off-by: qiwen li <[email protected]> * Update CHANGELOG.md Signed-off-by: Qiwen Li <[email protected]> * modify to match discover legacy behavior, columns from previous column are only shown in canvas area Signed-off-by: qiwen li <[email protected]> * Update CHANGELOG.md Co-authored-by: Anan Zhuang <[email protected]> Signed-off-by: Qiwen Li <[email protected]> * removed unused variables, added comments and @param Signed-off-by: Qiwen Li <[email protected]> --------- Signed-off-by: qiwen li <[email protected]> Signed-off-by: Qiwen Li <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 21, 2023
…CH (#5508) * Revert "[Data Explorer][Discover 2.0] Fix issues when change index pattern (#4875) (#4885)" This reverts commit 0102a32. try revert: * [osci23] implmented advance setting in Dicover: MODIFY_COLUMN_ON_SWITCH Signed-off-by: qiwen li <[email protected]> * fix deps Signed-off-by: qiwen li <[email protected]> * Update CHANGELOG.md Signed-off-by: Qiwen Li <[email protected]> * modify to match discover legacy behavior, columns from previous column are only shown in canvas area Signed-off-by: qiwen li <[email protected]> * Update CHANGELOG.md Co-authored-by: Anan Zhuang <[email protected]> Signed-off-by: Qiwen Li <[email protected]> * removed unused variables, added comments and @param Signed-off-by: Qiwen Li <[email protected]> --------- Signed-off-by: qiwen li <[email protected]> Signed-off-by: Qiwen Li <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> (cherry picked from commit 34994f8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 26, 2024
…CH (#5508) * Revert "[Data Explorer][Discover 2.0] Fix issues when change index pattern (#4875) (#4885)" This reverts commit 0102a32. try revert: * [osci23] implmented advance setting in Dicover: MODIFY_COLUMN_ON_SWITCH Signed-off-by: qiwen li <[email protected]> * fix deps Signed-off-by: qiwen li <[email protected]> * Update CHANGELOG.md Signed-off-by: Qiwen Li <[email protected]> * modify to match discover legacy behavior, columns from previous column are only shown in canvas area Signed-off-by: qiwen li <[email protected]> * Update CHANGELOG.md Co-authored-by: Anan Zhuang <[email protected]> Signed-off-by: Qiwen Li <[email protected]> * removed unused variables, added comments and @param Signed-off-by: Qiwen Li <[email protected]> --------- Signed-off-by: qiwen li <[email protected]> Signed-off-by: Qiwen Li <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> (cherry picked from commit 34994f8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
manasvinibs
pushed a commit
that referenced
this pull request
Jan 31, 2024
…CH (#5508) * Revert "[Data Explorer][Discover 2.0] Fix issues when change index pattern (#4875) (#4885)" This reverts commit 0102a32. try revert: * [osci23] implmented advance setting in Dicover: MODIFY_COLUMN_ON_SWITCH Signed-off-by: qiwen li <[email protected]> * fix deps Signed-off-by: qiwen li <[email protected]> * Update CHANGELOG.md Signed-off-by: Qiwen Li <[email protected]> * modify to match discover legacy behavior, columns from previous column are only shown in canvas area Signed-off-by: qiwen li <[email protected]> * Update CHANGELOG.md Co-authored-by: Anan Zhuang <[email protected]> Signed-off-by: Qiwen Li <[email protected]> * removed unused variables, added comments and @param Signed-off-by: Qiwen Li <[email protected]> --------- Signed-off-by: qiwen li <[email protected]> Signed-off-by: Qiwen Li <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> (cherry picked from commit 34994f8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
manasvinibs
pushed a commit
that referenced
this pull request
Jan 31, 2024
…CH (#5508) * Revert "[Data Explorer][Discover 2.0] Fix issues when change index pattern (#4875) (#4885)" This reverts commit 0102a32. try revert: * [osci23] implmented advance setting in Dicover: MODIFY_COLUMN_ON_SWITCH Signed-off-by: qiwen li <[email protected]> * fix deps Signed-off-by: qiwen li <[email protected]> * Update CHANGELOG.md Signed-off-by: Qiwen Li <[email protected]> * modify to match discover legacy behavior, columns from previous column are only shown in canvas area Signed-off-by: qiwen li <[email protected]> * Update CHANGELOG.md Co-authored-by: Anan Zhuang <[email protected]> Signed-off-by: Qiwen Li <[email protected]> * removed unused variables, added comments and @param Signed-off-by: Qiwen Li <[email protected]> --------- Signed-off-by: qiwen li <[email protected]> Signed-off-by: Qiwen Li <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> (cherry picked from commit 34994f8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
manasvinibs
pushed a commit
that referenced
this pull request
Jan 31, 2024
…CH (#5508) (#5746) * Revert "[Data Explorer][Discover 2.0] Fix issues when change index pattern (#4875) (#4885)" This reverts commit 0102a32. try revert: * [osci23] implmented advance setting in Dicover: MODIFY_COLUMN_ON_SWITCH Signed-off-by: qiwen li <[email protected]> * fix deps Signed-off-by: qiwen li <[email protected]> * Update CHANGELOG.md Signed-off-by: Qiwen Li <[email protected]> * modify to match discover legacy behavior, columns from previous column are only shown in canvas area Signed-off-by: qiwen li <[email protected]> * Update CHANGELOG.md Co-authored-by: Anan Zhuang <[email protected]> Signed-off-by: Qiwen Li <[email protected]> * removed unused variables, added comments and @param Signed-off-by: Qiwen Li <[email protected]> --------- Signed-off-by: qiwen li <[email protected]> Signed-off-by: Qiwen Li <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> (cherry picked from commit 34994f8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ashwin-pc
pushed a commit
that referenced
this pull request
Feb 5, 2024
…CH (#5508) (#5638) * Revert "[Data Explorer][Discover 2.0] Fix issues when change index pattern (#4875) (#4885)" This reverts commit 0102a32. try revert: * [osci23] implmented advance setting in Dicover: MODIFY_COLUMN_ON_SWITCH Signed-off-by: qiwen li <[email protected]> * fix deps Signed-off-by: qiwen li <[email protected]> * Update CHANGELOG.md Signed-off-by: Qiwen Li <[email protected]> * modify to match discover legacy behavior, columns from previous column are only shown in canvas area Signed-off-by: qiwen li <[email protected]> * Update CHANGELOG.md Co-authored-by: Anan Zhuang <[email protected]> Signed-off-by: Qiwen Li <[email protected]> * removed unused variables, added comments and @param Signed-off-by: Qiwen Li <[email protected]> --------- Signed-off-by: qiwen li <[email protected]> Signed-off-by: Qiwen Li <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> (cherry picked from commit 34994f8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 9958799 from #4875.