[Backport 2.x] [BUG] Fix management overview page duplicate rendering #4871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* refactor for management overview page Signed-off-by: Hailong Cui <[email protected]> * Add missing changelog Signed-off-by: Hailong Cui <[email protected]> * Add unit test Signed-off-by: Hailong Cui <[email protected]> * remove duplicate snapshot validation Signed-off-by: Hailong Cui <[email protected]> * Update src/plugins/management_overview/public/application.test.tsx Co-authored-by: Josh Romero <[email protected]> Signed-off-by: Hailong Cui <[email protected]> * Update src/plugins/management_overview/public/application.test.tsx Co-authored-by: Josh Romero <[email protected]> Signed-off-by: Hailong Cui <[email protected]> * export empty plugin start to make it consistent Signed-off-by: Hailong Cui <[email protected]> * export empty plugin start to make it consistent Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> Co-authored-by: Josh Romero <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> (cherry picked from commit 16b1e29) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr and
abbyhu2000
as code owners
opensearch-trigger-bot
bot
added
autocut
opensearch-trigger-bot
bot
requested a review
from zengyan-amazon
as a code owner
opensearch-trigger-bot
bot
requested review from
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub and
BSFishy
as code owners
Codecov Report
@@ Coverage Diff @@
## 2.x #4871 +/- ##
==========================================
+ Coverage 66.29% 66.31% +0.02%
==========================================
Files 3322 3323 +1
Lines 63911 63924 +13
Branches 10119 10120 +1
==========================================
+ Hits 42368 42394 +26
+ Misses 19053 19044 -9
+ Partials 2490 2486 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
kavilla
approved these changes
Sep 1, 2023
manasvinibs
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 16b1e29 from #4636.