Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Next Theme] Make next theme the default #4854

Merged
merged 3 commits into from
Aug 31, 2023
Merged

[Next Theme] Make next theme the default #4854

merged 3 commits into from
Aug 31, 2023

Conversation

joshuarrrr
Copy link
Member

Description

Issues Resolved

Fixes #4677

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@joshuarrrr
Make v8 theme default
296f8db 
Signed-off-by: Josh Romero <[email protected]>
@codecov
Copy link

codecov bot commented Aug 30, 2023 •
edited
Loading

Codecov Report

Merging #4854 (e300086) into main (ce2d79e) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4854      +/-   ##
==========================================
- Coverage   66.39%   66.39%   -0.01%     
==========================================
  Files        3396     3396              
  Lines       64801    64801              
  Branches    10359    10359              
==========================================
- Hits        43025    43023       -2     
- Misses      19217    19218       +1     
- Partials     2559     2560       +1
Flag Coverage Δ
Linux_1 34.85% <100.00%> (ø)
Linux_2 55.15% <ø> (ø)
Linux_3 44.23% <100.00%> (ø)
Linux_4 34.92% <100.00%> (ø)
Windows_1 34.87% <100.00%> (ø)
Windows_2 55.12% <ø> (ø)
Windows_3 44.23% <100.00%> (ø)
Windows_4 34.92% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/core/server/ui_settings/settings/theme.ts 100.00% <ø> (ø)
src/core/server/ui_settings/ui_settings_config.ts 100.00% <ø> (ø)
packages/osd-ui-shared-deps/theme.ts 41.66% <100.00%> (ø)

... and 1 file with indirect coverage changes

AMoo-Miki
AMoo-Miki previously approved these changes Aug 30, 2023
View reviewed changes
@joshuarrrr
update changelog
4b6e721 
Signed-off-by: Josh Romero <[email protected]>
@ashwin-pc ashwin-pc merged commit 9d7f576 into opensearch-project:main Aug 31, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 31, 2023
@github-actions
[Next Theme] Make next theme the default (#4854)
e211b36 
* Make v8 theme default

Signed-off-by: Josh Romero <[email protected]>

* update changelog

Signed-off-by: Josh Romero <[email protected]>

---------

Signed-off-by: Josh Romero <[email protected]>
Co-authored-by: Miki <[email protected]>
(cherry picked from commit 9d7f576)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Aug 31, 2023
Merged
@joshuarrrr joshuarrrr deleted the feat/make-next-theme-default branch August 31, 2023 23:34
joshuarrrr added a commit that referenced this pull request Sep 1, 2023
@opensearch-trigger-bot @github-actions @joshuarrrr
[Next Theme] Make next theme the default (#4854) (#4887)
9eb1ca3 
* Make v8 theme default

Signed-off-by: Josh Romero <[email protected]>

* update changelog

Signed-off-by: Josh Romero <[email protected]>

---------

Signed-off-by: Josh Romero <[email protected]>
Co-authored-by: Miki <[email protected]>
(cherry picked from commit 9d7f576)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Josh Romero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwin-pc ashwin-pc ashwin-pc approved these changes

@AMoo-Miki AMoo-Miki AMoo-Miki approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@seanneumann seanneumann Awaiting requested review from seanneumann

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@kristenTian kristenTian Awaiting requested review from kristenTian

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@BSFishy BSFishy Awaiting requested review from BSFishy

@curq curq Awaiting requested review from curq curq is a code owner

Assignees
No one assigned
Labels
backport 2.x v2.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch default theme to "Next" from "V7"
3 participants
@joshuarrrr @AMoo-Miki @ashwin-pc