Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual Backport 2.x] Merged [Dashboards] restructure folder to be more cohesive with the project (#4575) #4683

Merged

Conversation

joshuarrrr
Copy link
Member

backport 2b725a9 from #4575

…pensearch-project#4575)

Fast follow to:
opensearch-project#4502

* Cleanup to just use `utils`
* Move empty screen into embeddables folder with related features
* Get rid of the export file in favor matching other plugins
* Combine folders of components that are related, e.g., top_nav

Issue:
opensearch-project#4574

Signed-off-by: Kawika Avilla <[email protected]>
(cherry picked from commit 2b725a9)
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #4683 (ad5735b) into 2.x (f943320) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              2.x    #4683   +/-   ##
=======================================
  Coverage   66.10%   66.11%           
=======================================
  Files        3315     3315           
  Lines       63891    63891           
  Branches    10121    10121           
=======================================
+ Hits        42238    42240    +2     
+ Misses      19171    19167    -4     
- Partials     2482     2484    +2     
Flag Coverage Δ
Linux_1 34.77% <ø> (ø)
Linux_2 55.07% <ø> (ø)
Linux_3 43.05% <ø> (-0.04%) ⬇️
Linux_4 35.10% <ø> (ø)
Windows_1 34.78% <ø> (ø)
Windows_2 55.03% <ø> (ø)
Windows_3 43.05% <ø> (-0.05%) ⬇️
Windows_4 35.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...blic/application/actions/add_to_library_action.tsx 54.54% <ø> (ø)
.../public/application/actions/clone_panel_action.tsx 68.57% <ø> (ø)
...public/application/actions/expand_panel_action.tsx 47.36% <ø> (ø)
...pplication/actions/library_notification_action.tsx 54.54% <ø> (ø)
.../application/actions/open_replace_panel_flyout.tsx 50.00% <ø> (ø)
...ublic/application/actions/replace_panel_action.tsx 60.00% <ø> (ø)
...ublic/application/actions/replace_panel_flyout.tsx 0.00% <ø> (ø)
...application/actions/unlink_from_library_action.tsx 54.54% <ø> (ø)
...ion/components/dashboard_listing/create_button.tsx 91.66% <ø> (ø)
...components/dashboard_listing/dashboard_listing.tsx 3.27% <ø> (ø)
... and 36 more

... and 3 files with indirect coverage changes

Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@abbyhu2000 abbyhu2000 merged commit ceaaeb1 into opensearch-project:2.x Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants