[Backport 2.x] [Console] Convert lib/mappings to TypeScript #4500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Convert mappings.js to TypeScript Signed-off-by: Sirazh Gabdullin <[email protected]> * Convert mappings.test.js to TypeScript Signed-off-by: Sirazh Gabdullin <[email protected]> * Update CHANGELOG.md Signed-off-by: Sirazh Gabdullin <[email protected]> * Add test for getTypes with multi-index mode Signed-off-by: Sirazh Gabdullin <[email protected]> * type update Signed-off-by: Sirazh Gabdullin <[email protected]> * update typing Signed-off-by: Sirazh Gabdullin <[email protected]> * CHANGELOG fix Signed-off-by: Sirazh Gabdullin <[email protected]> * Changelog update Signed-off-by: Sirazh Gabdullin <[email protected]> * Update Changelog Signed-off-by: Sirazh Gabdullin <[email protected]> --------- Signed-off-by: Sirazh Gabdullin <[email protected]> Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Josh Romero <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Co-authored-by: Kawika Avilla <[email protected]> Co-authored-by: Qingyang(Abby) Hu <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit e07c5e6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
opensearch-trigger-bot
bot
requested review from
ananzh and
kavilla
as code owners
opensearch-trigger-bot
bot
added
the
autocut
opensearch-trigger-bot
bot
added
OSCI
opensearch-trigger-bot
bot
requested review from
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub and
BSFishy
as code owners
Codecov Report
@@ Coverage Diff @@
## 2.x #4500 +/- ##
==========================================
- Coverage 66.41% 66.40% -0.02%
==========================================
Files 3245 3245
Lines 62435 62439 +4
Branches 9672 9710 +38
==========================================
- Hits 41469 41462 -7
- Misses 18621 18622 +1
- Partials 2345 2355 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ananzh
approved these changes
Jul 5, 2023
manasvinibs
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport e07c5e6 from #4008.