Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Anywhere] Fix bug of charts in view events flyout not fetching vislayers #4443

Conversation

ohltyler
Copy link
Member

@ohltyler ohltyler commented Jun 29, 2023

Description

There was some recent bug fixes to prevent fetching vislayers in the context of the vis edit flow. This fix missed the scenario of rendering the charts in the view events flyout. This fixes that by checking the config that is passed to the visualize_embeddable, and checking if in the flyout context or not.

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #4443 (9d0f515) into feature/feature-anywhere (45ecc1f) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@                     Coverage Diff                      @@
##           feature/feature-anywhere    #4443      +/-   ##
============================================================
- Coverage                     66.43%   66.37%   -0.06%     
============================================================
  Files                          3287     3287              
  Lines                         63258    63256       -2     
  Branches                       9796     9797       +1     
============================================================
- Hits                          42026    41989      -37     
- Misses                        18868    18897      +29     
- Partials                       2364     2370       +6     
Flag Coverage Δ
Linux 66.37% <0.00%> (+<0.01%) ⬆️
Windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...izations/public/embeddable/visualize_embeddable.ts 19.31% <0.00%> (ø)

... and 10 files with indirect coverage changes

@joshuarrrr joshuarrrr merged commit 70a9ee0 into opensearch-project:feature/feature-anywhere Jun 29, 2023
@ohltyler ohltyler deleted the fix-event-charts branch June 30, 2023 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants