Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] fix icons in stack management #441

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Jun 4, 2021

Description

Icons were renamed from kql to dql which doesn't exist. Restoring the
correct icon fixes the error in the browser as well.

Signed-off-by: Kawika Avilla [email protected]

Issues Resolved

#431

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

Icons were renamed from `kql` to `dql` which doesn't exist. Restoring the
correct icon fixes the error in the browser as well.

Issues resolved:
opensearch-project#431

Signed-off-by: Kawika Avilla <[email protected]>
@kavilla kavilla force-pushed the avillk/fix_settings_icons branch from 354ae1c to 66b1036 Compare June 4, 2021 19:40
@kavilla kavilla changed the title [Build] fix icons in settings [Build] fix icons in stack management Jun 4, 2021
@kavilla kavilla linked an issue Jun 4, 2021 that may be closed by this pull request
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 66b1036

@kavilla kavilla added branding build Build related additions or modifications labels Jun 4, 2021
Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kavilla kavilla merged commit 6a35fe8 into opensearch-project:main Jun 4, 2021
kavilla added a commit that referenced this pull request Jun 4, 2021
Icons were renamed from `kql` to `dql` which doesn't exist. Restoring the
correct icon fixes the error in the browser as well.

Issues resolved:
#431

Signed-off-by: Kawika Avilla <[email protected]>
kavilla added a commit that referenced this pull request Jun 4, 2021
Icons were renamed from `kql` to `dql` which doesn't exist. Restoring the
correct icon fixes the error in the browser as well.

Issues resolved:
#431

Signed-off-by: Kawika Avilla <[email protected]>
@kavilla kavilla deleted the avillk/fix_settings_icons branch June 4, 2021 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branding build Build related additions or modifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Icons fail to load in Stack Management
4 participants