Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lmdb-store to fix backport issue #4266

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Jun 8, 2023

Issue Resolve
#4260

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@ananzh ananzh force-pushed the 2.x-remove-lmdb-store branch from 2ebc965 to 986eb8c Compare June 8, 2023 20:40
@ananzh ananzh added the bug Something isn't working label Jun 8, 2023
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #4266 (2ebc965) into 2.x (0196d91) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 2ebc965 differs from pull request most recent head 986eb8c. Consider uploading reports for the commit 986eb8c to get more accurate results

@@            Coverage Diff             @@
##              2.x    #4266      +/-   ##
==========================================
+ Coverage   66.36%   66.38%   +0.01%     
==========================================
  Files        3229     3229              
  Lines       62121    62121              
  Branches     9619     9619              
==========================================
+ Hits        41229    41241      +12     
+ Misses      18572    18560      -12     
  Partials     2320     2320              
Flag Coverage Δ
Linux 66.31% <ø> (+<0.01%) ⬆️
Windows 66.33% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@ananzh ananzh merged commit 3409412 into opensearch-project:2.x Jun 9, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.8 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.8 2.8
# Navigate to the new working tree
pushd ../.worktrees/backport-2.8
# Create a new branch
git switch --create backport/backport-4266-to-2.8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 34094129a14a6811e509dcaae51d516dd1f8c24b
# Push it to GitHub
git push --set-upstream origin backport/backport-4266-to-2.8
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.8

Then, create a pull request where the base branch is 2.8 and the compare/head branch is backport/backport-4266-to-2.8.

@AMoo-Miki
Copy link
Collaborator

Went into 2.x with #4203 and out with 2.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v2.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants