Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle Node 14 and allow fallback to Node 14 #4141

Closed
wants to merge 3 commits into from

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented May 25, 2023

Description

Blocked by #4071

This is resolving some backward issues to build on Node 18 for this PR #4071 . The changes include:

  • getNodeVersionDownloadInfo is responsible for generating the download information for a specific version of Node.js given the version number, architecture (e.g., x64), and the operating system.
  • Node.js 14 binaries are downloaded and copied to node/fallback directory in the build path specific to a platform.
  • Check if the desired Node.js version is available and executable, and if it is not, falling back to the path where Node.js 14 is stored (the "fallback" directory).

Issues Resolved

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@AMoo-Miki
Copy link
Collaborator

Superseded by #4151

@AMoo-Miki AMoo-Miki closed this May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants