Context menu group flattening #4072
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Sinclair <[email protected]>
Signed-off-by: David Sinclair <[email protected]>
Signed-off-by: David Sinclair <[email protected]>
Signed-off-by: David Sinclair <[email protected]>
…m:sikhote/OpenSearch-Dashboards into enhance-grouping-for-context-menu-options Signed-off-by: David Sinclair <[email protected]>
Signed-off-by: David Sinclair <[email protected]>
…m:sikhote/OpenSearch-Dashboards into enhance-grouping-for-context-menu-options Signed-off-by: David Sinclair <[email protected]>
Signed-off-by: David Sinclair <[email protected]>
…m:sikhote/OpenSearch-Dashboards into enhance-grouping-for-context-menu-options Signed-off-by: David Sinclair <[email protected]>
Signed-off-by: David Sinclair <[email protected]>
Signed-off-by: David Sinclair <[email protected]>
Signed-off-by: David Sinclair <[email protected]>
sikhote
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu and
manasvinibs
as code owners
Signed-off-by: David Sinclair <[email protected]>
Signed-off-by: David Sinclair <[email protected]>
|
This approach did not work and is replaced by #4144 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows a group within a context menu to be flattened. Typically, a group within a context menu has it's own separate option within a context menu, which can be clicked into to show deeper options. This feature allows a group to be flattened within the main menu. The need being filled is to allow grouping multiple items, but without relying on order to do so and providing a separator between the group and any other groups.
This builds on the work completed in #3924
Issues Resolved
#4073
Screenshot
Testing the changes
These changes can be tested using the regular testing suite, or by visiting the example page locally at http://localhost:5601/app/uiActionsExplorer
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr